From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751106AbcBMHBY (ORCPT <rfc822;w@1wt.eu>);
	Sat, 13 Feb 2016 02:01:24 -0500
Received: from mail-ig0-f171.google.com ([209.85.213.171]:34705 "EHLO
	mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750875AbcBMHBX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 13 Feb 2016 02:01:23 -0500
MIME-Version: 1.0
In-Reply-To: <2859000.sW5HDiH6vW@wuerfel>
References: <20160212092153.GA2368@deepa-ubuntu>
	<1455270349-3187-1-git-send-email-deepa.kernel@gmail.com>
	<1455270349-3187-4-git-send-email-deepa.kernel@gmail.com>
	<2859000.sW5HDiH6vW@wuerfel>
Date: Fri, 12 Feb 2016 23:01:22 -0800
Message-ID: <CABeXuvor=fR1B12e_yzpZUriwChSfNw-A83mx9_E=GKaeyGZgA@mail.gmail.com>
Subject: Re: [RFC v2b 3/5] fs: btrfs: Use vfs_time accessors
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
        Dave Chinner <david@fromorbit.com>, "Theodore Ts'o" <tytso@mit.edu>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 12, 2016 at 5:57 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 12 February 2016 01:45:47 Deepa Dinamani wrote:
>> +       ts = vfs_time_to_timespec(inode->i_mtime);
>> +       if (!timespec_equal(&ts, &now))
>> +               inode->i_mtime = timespec_to_vfs_time(now);
>> +
>> +       ts = vfs_time_to_timespec(inode->i_mtime);
>> +       if (!timespec_equal(&ts, &now))
>> +               inode->i_ctime = timespec_to_vfs_time(now);
>>
>
> The second one needs to be fs_time_to_timespec(inode->i_ctime), not i_mtime.


Yes, you are correct.
I will wait for some consensus on the proposal to figure out which
version to post again.

Thanks,
-Deepa