From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbcFJAxO (ORCPT ); Thu, 9 Jun 2016 20:53:14 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:34800 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbcFJAxM (ORCPT ); Thu, 9 Jun 2016 20:53:12 -0400 MIME-Version: 1.0 In-Reply-To: <20160609074131.GB2790@quack2.suse.cz> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-7-git-send-email-deepa.kernel@gmail.com> <20160609074131.GB2790@quack2.suse.cz> From: Deepa Dinamani Date: Thu, 9 Jun 2016 17:53:10 -0700 Message-ID: Subject: Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time() To: Jan Kara Cc: Linux FS-devel Mailing List , Linux Kernel Mailing List , Arnd Bergmann , Thomas Gleixner , Al Viro , Linus Torvalds , y2038@lists.linaro.org, Jan Kara Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 9, 2016 at 12:41 AM, Jan Kara wrote: > On Wed 08-06-16 22:04:50, Deepa Dinamani wrote: >> Logical Volume Integrity format is described to have the >> same timestamp format for "Recording Date and time" as >> the other [a,c,m]timestamps. >> Hence using current_fs_time() instead here promises to >> maintain the same granularity as other timestamps. >> > Just one nit below. > >> @@ -2030,7 +2030,7 @@ static void udf_close_lvid(struct super_block *sb) >> - udf_time_to_disk_stamp(&lvid->recordingDateAndTime, CURRENT_TIME); >> + udf_time_to_disk_stamp(&lvid->recordingDateAndTime, current_fs_time(sb)); > > Please wrap this line properly so that it does not exceed 80 characters. > Other than that feel free to add: > > Reviewed-by: Jan Kara Thanks, I will take care of this in v2 of the patch series. - Deepa