From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
dbueso@suse.de, axboe@kernel.dk,
Davidlohr Bueso <dave@stgolabs.net>,
Jason Baron <jbaron@akamai.com>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
linux-aio <linux-aio@kvack.org>,
Omar Kilani <omar.kilani@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
stable@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask()
Date: Tue, 21 May 2019 17:44:19 -0700 [thread overview]
Message-ID: <CABeXuvrT-mHomeH-CnuLsWzNCQOfymW01s+HGRaBTNA+u2t28w@mail.gmail.com> (raw)
In-Reply-To: <CABeXuvoOGwOGmSz_vgTugLD1NPE=2ULvmESPTtK9d6r8S+WVdQ@mail.gmail.com>
On Tue, May 21, 2019 at 5:35 PM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>
> > > > It's been 2 weeks and this fix hasn't appeared in mmots / mmotm.
> > > > I also noticed it's missing Cc: for stable@ (below)
> > >
> > > Why is a -stable backport needed? I see some talk above about lost
> > > signals but it is unclear whether these are being observed after fixing
> > > the regression caused by 854a6ed56839a.
> >
> > I guess Deepa's commit messages wasn't clear...
> > I suggest prepending this as the first paragraph to Deepa's
> > original message:
> >
> > This fixes a bug introduced with 854a6ed56839a which caused
> > EINTR to not be reported to userspace on epoll_pwait. Failure
> > to report EINTR to userspace caused problems with user code
> > which relies on EINTR to run signal handlers.
>
> This is not what the patch fixed.
>
> The notable change is userspace is that now whenever a signal is
> delivered, the return value is adjusted to reflect the signal
> delivery.
> Prior to this patch, there was a window, however small it might have
> been, when the signal was delivered but the errono was not adjusted
> appropriately.
> This is because of the regression caused by 854a6ed56839a, which
> extended the window of delivery of signals that was delivered to
> userspace.
> The patch also fixes more than sys_epoll_pwait().
>
> I will post a follow up patch.
>
> >
> > > IOW, can we please have a changelog which has a clear and complete
> > > description of the user-visible effects of the change.
> > >
> > > And please Cc Oleg.
>
> I will cc Oleg.
Also the commit message was brief because the issue was explained in
the link that was quoted in the commit message.
Detailed issue discussion permalink:
https://lore.kernel.org/linux-fsdevel/20190427093319.sgicqik2oqkez3wk@dcvr/
-Deepa
prev parent reply other threads:[~2019-05-22 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 4:39 [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask() Deepa Dinamani
2019-05-21 9:25 ` Eric Wong
2019-05-21 22:27 ` Andrew Morton
2019-05-21 23:33 ` Eric Wong
2019-05-22 0:35 ` Deepa Dinamani
2019-05-22 0:44 ` Deepa Dinamani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABeXuvrT-mHomeH-CnuLsWzNCQOfymW01s+HGRaBTNA+u2t28w@mail.gmail.com \
--to=deepa.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=e@80x24.org \
--cc=jbaron@akamai.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=omar.kilani@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).