From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
linux-aio <linux-aio@kvack.org>
Subject: Re: [PATCH v2 4/5] pselect6: use __kernel_timespec
Date: Sat, 15 Sep 2018 12:04:11 -0700 [thread overview]
Message-ID: <CABeXuvrU_B0gFhdHiYvEAUgDMso_94=M8iPJj+w7N1LnGMrKAw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1809152039440.1650@nanos.tec.linutronix.de>
On Sat, Sep 15, 2018 at 11:42 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Sat, 15 Sep 2018, Deepa Dinamani wrote:
>
> > On Sat, Sep 15, 2018 at 8:28 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > >
> > > On Sat, Sep 15, 2018 at 7:09 AM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> > >
> > > > +#if defined(CONFIG_64BIT_TIME)
> > > > +
> > > > +COMPAT_SYSCALL_DEFINE6(pselect6_time64, int, n, compat_ulong_t __user *, inp,
> > > > + compat_ulong_t __user *, outp, compat_ulong_t __user *, exp,
> > > > + struct __kernel_timespec __user *, tsp, void __user *, sig)
> > >
> > > I got a link error here since compat_sys_pselect6_time64 and
> > > compat_sys_ppoll_time64 are only defined when CONFIG_64BIT_TIME
> > > is set.
> > >
> > > I did not think we would select this symbol on arm64, is that a mistake
> > > on my side, or should the #ifdef check be removed?
> >
> > But, this is a compat syscall.
> > When we introduced this CONFIG_64BIT_TIME we planned to use it for
> > compat syscalls also is my understanding.
> >
> > config 64BIT_TIME
> > def_bool ARCH_HAS_64BIT_TIME
> > help
> > This should be selected by all architectures that need to support
> > new system calls with a 64-bit time_t. This is relevant on all 32-bit
> > architectures, and 64-bit architectures as part of compat syscall
> > handling.
> >
> > This means it should be set on 64 bit architechtures also right?
>
> It's only set when 32bit compat mode is enabled on the 64bit kernel.
Ok, then we could delete the #ifdef like Arnd suggested. So this will
be defined for all architectures that enable CONFIG_COMPAT
unconditionally.
I will post an updated version.
Thanks,
Deepa
next prev parent reply other threads:[~2018-09-15 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 5:08 [PATCH v2 0/5] y2038: Make ppoll, io_pgetevents and pselect y2038 safe Deepa Dinamani
2018-09-15 5:08 ` [PATCH v2 1/5] signal: Add set_user_sigmask() Deepa Dinamani
2018-09-15 5:08 ` [PATCH v2 2/5] signal: Add restore_user_sigmask() Deepa Dinamani
2018-09-15 5:08 ` [PATCH v2 3/5] ppoll: use __kernel_timespec Deepa Dinamani
2018-09-15 5:08 ` [PATCH v2 4/5] pselect6: " Deepa Dinamani
2018-09-15 15:27 ` Arnd Bergmann
2018-09-15 18:37 ` Deepa Dinamani
2018-09-15 18:42 ` Thomas Gleixner
2018-09-15 19:04 ` Deepa Dinamani [this message]
2018-09-15 5:08 ` [PATCH v2 5/5] io_pgetevents: " Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABeXuvrU_B0gFhdHiYvEAUgDMso_94=M8iPJj+w7N1LnGMrKAw@mail.gmail.com' \
--to=deepa.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).