From: Steve Lee <steves.lee.maxim@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Tzung-Bi Shih" <tzungbi@google.com>,
jack.yu@realtek.com,
"ALSA development" <alsa-devel@alsa-project.org>,
ryan.lee.maxim@gmail.com, ckeepax@opensource.cirrus.com,
ryans.lee@maximintegrated.com, steves.lee@maximintegrated.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
nuno.sa@analog.com, geert@linux-m68k.org, dmurphy@ti.com,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Srini Kandagatla" <srinivas.kandagatla@linaro.org>,
rf@opensource.wolfsonmicro.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver
Date: Thu, 14 May 2020 21:14:04 +0900 [thread overview]
Message-ID: <CABff4NQh8ZtHUfn4KYcXfgbZgiaRQb_5s5e7sq0_jZkp2OMg4Q@mail.gmail.com> (raw)
In-Reply-To: <20200514101711.GC5127@sirena.org.uk>
On Thu, May 14, 2020 at 7:17 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote:
> > On Wed, May 13, 2020 at 6:53 PM Mark Brown <broonie@kernel.org> wrote:
> > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
>
> > > > Changes since V2:
> > > > * Removed warn massage in max98390_dsm_calib_get func
> > > > and add comment.
>
> > > The problem isn't the warning, the problem is that you have an empty
> > > operation. You should either implement the function (eg, by caching the
> > > value written) or remove it and fix whatever problems you were running
> > > into further up the stack when it's missing.
>
> > The purpose for the mixer control is: to signal max98390 to start to
> > calibrate from userspace.
> > Thus,
> > max98390_dsm_calib_get() -> do nothing.
> > max98390_dsm_calib_put() -> call max98390_dsm_calibrate().
>
> In that case it should probably do something like read back if a
> callibration is currently running.
Thanks for feedback. I will follow this guide.
next prev parent reply other threads:[~2020-05-14 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 7:45 [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver Steve Lee
2020-05-13 10:51 ` Mark Brown
2020-05-13 11:58 ` Tzung-Bi Shih
2020-05-14 10:17 ` Mark Brown
2020-05-14 12:14 ` Steve Lee [this message]
2020-05-14 7:31 ` Tzung-Bi Shih
2020-05-14 10:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABff4NQh8ZtHUfn4KYcXfgbZgiaRQb_5s5e7sq0_jZkp2OMg4Q@mail.gmail.com \
--to=steves.lee.maxim@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).