From: Steve Lee <steves.lee.maxim@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
rf@opensource.wolfsonmicro.com,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Srini Kandagatla" <srinivas.kandagatla@linaro.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
dmurphy@ti.com, jack.yu@realtek.com, nuno.sa@analog.com,
steves.lee@maximintegrated.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"ALSA development" <alsa-devel@alsa-project.org>,
ryan.lee.maxim@gmail.com
Subject: Re: [PATCH 2/2] ASoC: max98390: Added Amplifier Driver
Date: Wed, 13 May 2020 13:05:32 +0900 [thread overview]
Message-ID: <CABff4NTm77Cr+FwO8p0-3AKBCWOvzXaHfdbP8guzWQ2Zzcrobg@mail.gmail.com> (raw)
In-Reply-To: <20200512103316.GB5110@sirena.org.uk>
On Tue, May 12, 2020 at 7:33 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, May 12, 2020 at 06:13:05PM +0900, Steve Lee wrote:
> > On Mon, May 11, 2020 at 8:03 PM Mark Brown <broonie@kernel.org> wrote:
>
> > > > +static const char * const max98390_current_limit_text[] = {
> > > > + "0.00A", "0.50A", "1.00A", "1.05A", "1.10A", "1.15A", "1.20A", "1.25A",
> > > > + "1.30A", "1.35A", "1.40A", "1.45A", "1.50A", "1.55A", "1.60A", "1.65A",
>
> > > This looks like it should be in DT too.
>
> > Since this control is needed while running system according to system
> > battery situation.
> > I'd keep this mixer for further use.
>
> That's... interesting for a current limit, and sounds like it would
> have issues for the common case use of current limits to protect the
> hardware.
>
> > > > +static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol,
> > > > + struct snd_ctl_elem_value *ucontrol)
> > > > +{
> > > > + struct snd_soc_component *component =
> > > > + snd_soc_kcontrol_component(kcontrol);
> > > > +
> > > > + dev_warn(component->dev, "Get dsm_calib_get not supported\n");
> > > > +
> > > > + return 0;
> > > > +}
>
> > > Just don't implement the operation if you can't implement it.
>
> > If this not exist as dummy operation and all mixer was not working and
> > could not implement better idea.
>
> Could you be more specific about what you mean by "not working" or how
> simply not initializing the value returned fixes things please?
I mean that xhandler_get pointing to NULL makes mixer list unexpected operation.
I will do return fixed value without warn message.
>
> > Could you consider it as with warn message ?
>
> No, if there's a problem here we should fix it properly.
Thanks for feed back.I will do return fixed value without warn message.
next prev parent reply other threads:[~2020-05-13 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 3:19 [PATCH 2/2] ASoC: max98390: Added Amplifier Driver Steve Lee
2020-05-11 11:03 ` Mark Brown
2020-05-12 9:13 ` Steve Lee
2020-05-12 10:33 ` Mark Brown
2020-05-13 4:05 ` Steve Lee [this message]
2020-05-11 11:16 ` Tzung-Bi Shih
2020-05-12 9:17 ` Steve Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABff4NTm77Cr+FwO8p0-3AKBCWOvzXaHfdbP8guzWQ2Zzcrobg@mail.gmail.com \
--to=steves.lee.maxim@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).