From: Z Lim <zlim.lnx@gmail.com>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
daniel@iogearbox.net, Xi Wang <xi.wang@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] arm64: bpf: fix JIT stack setup
Date: Mon, 9 Nov 2015 12:00:29 -0800 [thread overview]
Message-ID: <CABg9mcvACuVK2=GBbnur94CsckN2TXRCCiXhX7A8jYQ7arMM+Q@mail.gmail.com> (raw)
In-Reply-To: <5640E135.2020007@linaro.org>
On Mon, Nov 9, 2015 at 10:08 AM, Shi, Yang <yang.shi@linaro.org> wrote:
> I added it to stay align with ARMv8 AAPCS to maintain the correct FP during
> function call. It makes us get correct stack backtrace.
>
> I think we'd better to keep compliant with ARMv8 AAPCS in BPF JIT prologue
> too.
>
> If nobody thinks it is necessary, we definitely could remove that change.
Oh no, I don't think anyone will say it's unnecessary!
I agree the A64_FP-related change is a good idea, so stack unwinding works.
How about splitting this into two patches? One for the BPF-related
bug, and another for A64 FP-handling.
Thanks again for tracking this down and improving things overall for arm64 :)
>
> Thanks,
> Yang
>
>
next prev parent reply other threads:[~2015-11-09 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 5:36 [PATCH] arm64: bpf: fix JIT stack setup Yang Shi
2015-11-08 2:27 ` Alexei Starovoitov
2015-11-08 22:29 ` Z Lim
2015-11-09 18:08 ` Shi, Yang
2015-11-09 20:00 ` Z Lim [this message]
2015-11-10 19:46 ` Shi, Yang
2015-11-11 3:11 ` Z Lim
-- strict thread matches above, loose matches on Subject: below --
2015-11-07 5:34 Yang Shi
2015-11-07 5:55 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABg9mcvACuVK2=GBbnur94CsckN2TXRCCiXhX7A8jYQ7arMM+Q@mail.gmail.com' \
--to=zlim.lnx@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=xi.wang@gmail.com \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).