From: Romain Perier <romain.perier@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Aviad Krawczyk <aviad.krawczyk@huawei.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Romain Perier <romain.perier@collabora.com>
Subject: Re: [PATCH v15 5/5] PCI: Remove PCI pool macro functions
Date: Tue, 21 Nov 2017 09:39:04 +0100 [thread overview]
Message-ID: <CABgxDoL=MTqLN3VSVKi9Kajn0q4ZfpxpZiyEeKAOWfpj4_wAOA@mail.gmail.com> (raw)
In-Reply-To: <20171120203449.GA16362@bhelgaas-glaptop.roam.corp.google.com>
Whoops, my bad. Sorry
Thanks,
Romain
2017-11-20 21:34 GMT+01:00 Bjorn Helgaas <helgaas@kernel.org>:
> On Mon, Nov 20, 2017 at 08:32:47PM +0100, Romain Perier wrote:
>> From: Romain Perier <romain.perier@collabora.com>
>>
>> Now that all the drivers use dma pool API, we can remove the macro
>> functions for PCI pool.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> Reviewed-by: Peter Senna Tschudin <peter.senna@collabora.com>
>
> I already acked this once on Oct 24. Please keep that ack and include
> it in any future postings so I don't have to deal with this again.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
>> ---
>> include/linux/pci.h | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 96c94980d1ff..d03b4a20033d 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1324,15 +1324,6 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>> #include <linux/pci-dma.h>
>> #include <linux/dmapool.h>
>>
>> -#define pci_pool dma_pool
>> -#define pci_pool_create(name, pdev, size, align, allocation) \
>> - dma_pool_create(name, &pdev->dev, size, align, allocation)
>> -#define pci_pool_destroy(pool) dma_pool_destroy(pool)
>> -#define pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
>> -#define pci_pool_zalloc(pool, flags, handle) \
>> - dma_pool_zalloc(pool, flags, handle)
>> -#define pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>> -
>> struct msix_entry {
>> u32 vector; /* kernel uses to write allocated vector */
>> u16 entry; /* driver uses to specify entry, OS writes */
>> --
>> 2.14.1
>>
prev parent reply other threads:[~2017-11-21 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 19:32 [PATCH v15 0/5] Replace PCI pool by DMA pool API Romain Perier
2017-11-20 19:32 ` [PATCH v15 1/5] block: DAC960: Replace PCI pool old API Romain Perier
2017-11-20 19:32 ` [PATCH v15 2/5] net: e100: " Romain Perier
2017-11-20 19:32 ` [PATCH v15 3/5] hinic: " Romain Perier
2017-11-20 19:32 ` [PATCH v15 4/5] scsi: mpt3sas: " Romain Perier
2017-12-05 3:20 ` Martin K. Petersen
2017-11-20 19:32 ` [PATCH v15 5/5] PCI: Remove PCI pool macro functions Romain Perier
2017-11-20 20:34 ` Bjorn Helgaas
2017-11-21 8:39 ` Romain Perier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgxDoL=MTqLN3VSVKi9Kajn0q4ZfpxpZiyEeKAOWfpj4_wAOA@mail.gmail.com' \
--to=romain.perier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aviad.krawczyk@huawei.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=romain.perier@collabora.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).