From: Josh Don <joshdon@google.com>
To: Tao Zhou <ouwen210@hotmail.com>
Cc: Phil Auld <pauld@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86 <x86@kernel.org>
Subject: Re: [tip: sched/core] sched/fair: Remove distribute_running from CFS bandwidth
Date: Mon, 8 Jun 2020 16:44:26 -0700 [thread overview]
Message-ID: <CABk29Ns_tziZ_vLzWhq3YDA=LtmCmcacDv+hEUbBVdFVV1w13Q@mail.gmail.com> (raw)
In-Reply-To: <BL0PR14MB3779AD967619031948957C549A850@BL0PR14MB3779.namprd14.prod.outlook.com>
Hi Tao,
On Mon, Jun 8, 2020 at 4:01 PM Tao Zhou <ouwen210@hotmail.com> wrote:
> After commit ab93a4bc955b, cfs_b->distribute_running is not used and
> removed. The lock/unlock protecting it are not removed and remain in
> the code. One benefit of removing them is that it can elimite the code
> size a little.
>
> Fixes: ab93a4bc955b ("sched/fair: Remove distribute_running from CFS bandwidth")
> ---
> kernel/sched/fair.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 35f4cc024dcf..cc2e1e839e03 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5089,9 +5089,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
> return;
>
> distribute_cfs_runtime(cfs_b);
> -
> - raw_spin_lock_irqsave(&cfs_b->lock, flags);
> - raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
> }
Thanks, I missed the now-useless lock acquire in my revert.
s/elimite/eliminate
Reviewed-by: Josh Don <joshdon@google.com>
Best,
Josh
next prev parent reply other threads:[~2020-06-08 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 22:52 [PATCH 0/2] Fix race in CFS bandwidth Josh Don
2020-04-10 22:52 ` [PATCH 1/2] sched: eliminate bandwidth race between throttling and distribution Josh Don
[not found] ` <CABk29NtxG8t6wHM6MDVFun7jxqRpupWr0d5dK57N2ecFbdSumw@mail.gmail.com>
2020-04-13 14:44 ` Phil Auld
2020-04-14 10:52 ` Peter Zijlstra
2020-05-01 18:22 ` [tip: sched/core] sched/fair: Eliminate " tip-bot2 for Paul Turner
2020-04-10 22:52 ` [PATCH 2/2] sched: remove distribute_running from CFS bandwidth Josh Don
2020-04-12 2:01 ` Josh Don
2020-04-13 14:49 ` Phil Auld
2020-04-14 10:54 ` Peter Zijlstra
2020-05-01 18:22 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Josh Don
[not found] ` <BL0PR14MB3779C02BB87DC4426C4761639A840@BL0PR14MB3779.namprd14.prod.outlook.com>
2020-06-08 14:53 ` Phil Auld
[not found] ` <BL0PR14MB3779AD967619031948957C549A850@BL0PR14MB3779.namprd14.prod.outlook.com>
2020-06-08 23:44 ` Josh Don [this message]
2020-06-09 0:28 ` Phil Auld
2020-04-12 2:03 ` [PATCH 0/2] Fix race in " Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABk29Ns_tziZ_vLzWhq3YDA=LtmCmcacDv+hEUbBVdFVV1w13Q@mail.gmail.com' \
--to=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ouwen210@hotmail.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).