From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE23C433F5 for ; Fri, 3 Sep 2021 01:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 814EE61041 for ; Fri, 3 Sep 2021 01:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344895AbhICBWW (ORCPT ); Thu, 2 Sep 2021 21:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbhICBWV (ORCPT ); Thu, 2 Sep 2021 21:22:21 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C11C061575 for ; Thu, 2 Sep 2021 18:21:22 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id r4so7304958ybp.4 for ; Thu, 02 Sep 2021 18:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FbnWfjPWbMqaUy77C85OvsHvKmk1fJxMRcsrhSEyptw=; b=B/RiRqDWqn3gSMhdV8ILZNJvnvwgprEvlAiLRjyfK6EYIvNOdZANmN61654XhWynuh o4SyIXauNA1Ic5YOr8t4SjpT/3AqqtvL2ffCfcNyPE2WJWObnumdg+GPyjNebwubBV+7 SOmzczK1xvtjcseWX+Ht2JhBygbwHotXVNC2jZICwZOBTQugQnTd7f7ThiTatxKmmIhk ANjxGf4xvWLeNQ/LVM29UkrLY64e9tgrAVsL+v8b9hXS3MC1eRH/uHo9Cm8JWYQK8+7/ IaAyVbpCMlSBM8HUrC1vTClfdJ3OsK4E3gsFo2JP+gtDbX8ZWZg8w7nXrGhbtdfC6Pam EDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FbnWfjPWbMqaUy77C85OvsHvKmk1fJxMRcsrhSEyptw=; b=UH3pyPvbeui1UEJDFDvt1vRmkUN8wt7VZfm+h3NeaZ42S9rwbS3K+s6yCLkMiLEhyH Bzi5cCiedLLPiBcCRRz5eZVmkIhS3L1q5jZLalQL405QIs+jlMTT0RZv36I+QkV6jwPG y46exB3N8uGUdXWaGMglSpwW9GVJlCyqBiTA3rGPiwdnNOmajX23msKUPdMbupK9p3+s 0Rne0SLYPsRBgvoIzUsWBBiRKXb6Q1uIF+XsDpCWsvY1bD8szZC8u5CK1prjv8lA2Fj7 m2GEGsDENC6T1iG+XkGFVjYdy8oANcYlb+R5t4pQk5+Gl6EZXFf6hQEdmslpc2M4KlPc kcLw== X-Gm-Message-State: AOAM530MW/7Y7S1dKaaVcSrWOGlFLLGkWOHWvC6X0RuLaEznTfK9V/iU o56CSeZvEZv7iZ6YlAZGI/LjwMy85bPJialSHYw/6A== X-Google-Smtp-Source: ABdhPJxoW+365yaXVacsVbgqdXRUGmiFd+AO+mo1bz+fKkwbsLg7I8giOS9V/G0liXBpEcPRio7MnYn9bce5+BqXZG8= X-Received: by 2002:a25:4254:: with SMTP id p81mr1549551yba.442.1630632080846; Thu, 02 Sep 2021 18:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20210820010403.946838-1-joshdon@google.com> <20210820010403.946838-2-joshdon@google.com> <20210902012206.cm6flytlp63c2h5v@oracle.com> In-Reply-To: <20210902012206.cm6flytlp63c2h5v@oracle.com> From: Josh Don Date: Thu, 2 Sep 2021 18:21:09 -0700 Message-ID: Subject: Re: [PATCH v3 1/4] sched: cgroup SCHED_IDLE support To: Daniel Jordan Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Paul Turner , Oleg Rombakh , Viresh Kumar , Steve Sistare , Tejun Heo , Rik van Riel , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 1, 2021 at 6:22 PM Daniel Jordan wrote: > > On Thu, Aug 19, 2021 at 06:04:00PM -0700, Josh Don wrote: > > +static int se_is_idle(struct sched_entity *se) > > +{ > > + return 0; > > +} > > I'm thinking !FAIR_GROUP_SCHED is a rare thing to behold? So not a big > deal, but I think this wants to be > > return task_has_idle_policy(task_of(se)); > > so buddies aren't set for SCHED_IDLE. Good point. Peter has merged this one already, do you want to send a patch?