From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC65C433DB for ; Tue, 23 Mar 2021 01:16:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC7EC6196E for ; Tue, 23 Mar 2021 01:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbhCWBPl (ORCPT ); Mon, 22 Mar 2021 21:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbhCWBPe (ORCPT ); Mon, 22 Mar 2021 21:15:34 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA75C061574 for ; Mon, 22 Mar 2021 18:15:32 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id v70so12791535qkb.8 for ; Mon, 22 Mar 2021 18:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=scplLgXPqqZKrtnIxgrt8tEocTmcj46ftQf4U6i2iYA=; b=nChjpddhcwjSCu3obF68BMXJY1m7YhqYrE9QDshrL1zxJwh0t9zHT3e82XFwk4t2Ar qVdTuKvAKNHw6QQcw/JnzStDKlhRHMoYXTj2zgbdt5e0H2Zo5E1GFc45NX55kQv1yxXh OgYUwCVqfMywOGcD5o7OpWp4u9/dak1QJNjAvL8DF9xqDz4LkwNFXIwxm2JtwxSxhox4 jq/wY7H/MHwkIf+kagLPOaii9x6tVzxc4p0EV/739TWZhTzT7q1gnC5FKE+wfYIJ8M55 vg2iFh8GcgDWw/t9RzZau3mAXgXE9Z/T7ZP/meWmseigZpUlu/leKot8ZuM99l1kqnps TNgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=scplLgXPqqZKrtnIxgrt8tEocTmcj46ftQf4U6i2iYA=; b=pTpmWzLUsM5nBYtrDXQi65EstcsNEtH0fl/s7pH6C6XBcN+Avey097JSj2VuopODMY Gm24h2xu2TaYMDlJGnGDcNJ3XRLnas1ZmqBrD4Wu0qNvhCYFFLhv4Bi+pJa6feNtB7Tb uxI3N62yspUtrD/VPbmTRibU/lT7wEuF6n5Dttsw6Q+y1hPj9kqaXm8xS6iAPCdHujtb eL6hEuA6zRcI2xbCJVXEkTGBAxfFABoNqUeYRn/Gxcu8EQQUrFFJ5OlulLBqwwcKj+o6 cht61cp5YDCdgkspZj8dg7/QQot6qRIqT/ncns8tNvcmTQxuegZIdpEHvlg5kinH/4E6 Ihkg== X-Gm-Message-State: AOAM530Fda1AJJk0sJ7vDqERhn3eiqadEO12ZryiPjRn0QEzgYjrfcW/ 0JFzJQRo9B6Dj8kn8KmkqEzHxApt4N3McehTuAvYqw== X-Google-Smtp-Source: ABdhPJzOpro7C1aQUTouUHfe7+0TwOaB6WkuLAry5pJTYJSt3nwE5fu2jXm5nj0XKPds1iiJecOf9/hZgeBYOrvEpJM= X-Received: by 2002:a37:a647:: with SMTP id p68mr3035984qke.189.1616462131596; Mon, 22 Mar 2021 18:15:31 -0700 (PDT) MIME-Version: 1.0 References: <20210319203253.3352417-1-joel@joelfernandes.org> <20210319203253.3352417-3-joel@joelfernandes.org> <20210320154632.GZ4746@worktop.programming.kicks-ass.net> In-Reply-To: <20210320154632.GZ4746@worktop.programming.kicks-ass.net> From: Josh Don Date: Mon, 22 Mar 2021 18:15:20 -0700 Message-ID: Subject: Re: [PATCH 2/6] sched: tagging interface for core scheduling To: Peter Zijlstra Cc: "Joel Fernandes (Google)" , Nishanth Aravamudan , Julien Desfossez , Tim Chen , Vineeth Pillai , Aaron Lu , Aubrey Li , Thomas Gleixner , linux-kernel , Ingo Molnar , torvalds@linux-foundation.org, fweisbec@gmail.com, Kees Cook , Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini , vineeth@bitbyteword.org, Chen Yu , Christian Brauner , Agata Gruza , Antonio Gomez Iglesias , graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com, Steven Rostedt , benbjiang@tencent.com, Alexandre Chartre , James.Bottomley@hansenpartnership.com, OWeisse@umich.edu, Dhaval Giani , "Hyser,Chris" , Hao Luo , Tom Lendacky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +static unsigned long sched_core_alloc_task_cookie(void) > > +{ > > + struct sched_core_task_cookie *ck = > > + kmalloc(sizeof(struct sched_core_task_cookie), GFP_KERNEL); > > struct sched_core_task_cookie *ck = kmalloc(sizeof(*ck), GFP_KERNEL); > > Also, those type names are unfortunately long.. > > > +static void sched_core_get_task_cookie(unsigned long cookie) > > +{ > > + struct sched_core_task_cookie *ptr = > > + (struct sched_core_task_cookie *)cookie; > > struct sched_core_task_cookie *ptr = (void *)cookie; > > Know your language and use it to avoid typing excessively long names :-) Good point, done. Keeping sched_core_task_cookie for now unless you'd prefer a replacement, since it is only used internally by coretag.c.