From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D17C4361A for ; Fri, 4 Dec 2020 20:09:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90D8D22CAD for ; Fri, 4 Dec 2020 20:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730794AbgLDUJx (ORCPT ); Fri, 4 Dec 2020 15:09:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbgLDUJw (ORCPT ); Fri, 4 Dec 2020 15:09:52 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54D54C0613D1; Fri, 4 Dec 2020 12:09:12 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id ck29so7102448edb.8; Fri, 04 Dec 2020 12:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4t1dy5iRiZB4Z+/OzIHXwSJSK8rY8jRfJx3So3UXm0Q=; b=NZHTcA6d7YsdqBUPEFkSI7fq7cm7J9Fw10khd8L5+/zmv4ZE+yE0bZ3nLcC1OeiL3p Y/MLmZRvjpBGboubpgbdGQRF4yKufCK1/3OJdu78bQjaOnjppmD0bwncrwtacJv84+y+ VtiAlzM7uusXvO+BizPMXmpyfYRePpCHw21IOBhfdM6nbZU4/LQI02E2BM3/SivKttOM QNe8snLLbTf3HKeDRBtc7DhaVr3JaJ6seo+B3PVTyk4MzoAIOpsfoKxJpI/7HJEDX/QV vb0NU0GLoenDmYTNN/wym/qb386OXKfFz8t+2+yk1+YewTL5hNMb9mNRLwiBb7QHwquB aUBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4t1dy5iRiZB4Z+/OzIHXwSJSK8rY8jRfJx3So3UXm0Q=; b=Zv6DKYHhvwZqiBuQMivVNQohl9dhFuevMKDHA7XljKCatQbTyFzbTKtcYLu7/oC+42 DnmfGiVHIHd2ppSlSDG7G+U03U9/rzAK5jWxOmt/IJSt2egTzD+/pNva49kIOY3cOPxg 7lHs2YAxiY3TG8SCXDjMED8EIJ6PbxpGRbg3aJJXqNCzDli4TIHxHAV57NQ1srMw6Rdx ZhyA7y+gr0mp+8d4P7mici4Ax3df8xuY1rtDvE3nSMQYPoFr3BohoeunzCGSX7jJ7SLU 4+IM/3KXwslEFzxi7g/FMGpkdIt/P2Cioa3bIHJXX0+Z9YKNarjxMMlIerHw0lY3OADH Hf+g== X-Gm-Message-State: AOAM533sdbJguASTrnMF+ECw88lrtkjUlLuJm+T9QBH6QZbyfrx00FsN zvrU7ZmRoipWP/lKi4ZT5W01ti0ZqdhQPziAc8o= X-Google-Smtp-Source: ABdhPJw29Ny5tk93CP19n/cXJG3k+SPWXKMugsVKasXMCXVwC8umIy/MOTY0KX2IylR0UdFMPeB5zvNKRAfkntxWNYs= X-Received: by 2002:aa7:d9c1:: with SMTP id v1mr9271107eds.115.1607112551102; Fri, 04 Dec 2020 12:09:11 -0800 (PST) MIME-Version: 1.0 References: <20201128225425.19300-1-adrien.grassein@gmail.com> <20201129220000.16550-1-adrien.grassein@gmail.com> <20201129224113.GS2234159@lunn.ch> <20201129230416.GT2234159@lunn.ch> <20201130222645.GG2073444@lunn.ch> In-Reply-To: <20201130222645.GG2073444@lunn.ch> From: Adrien Grassein Date: Fri, 4 Dec 2020 21:09:00 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option To: Andrew Lunn Cc: Florian Fainelli , fugang.duan@nxp.com, davem@davemloft.net, kuba@kernel.org, Rob Herring , netdev@vger.kernel.org, DTML , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, I'm not a kernel expert, but I try to find why these patches were needed in the FSL/Boundary kernel. I found that the pin muxing in the original kernel was not good for FEC. It's now working well with the mainline code. You can delete these patches. Thanks a lot, Regards, Adrien Le lun. 30 nov. 2020 =C3=A0 23:26, Andrew Lunn a =C3=A9cri= t : > > > >> I am currently upstreaming the "Nitrogen 8m Mini board" that seems t= o not use a > > >> "normal" mdio bus but a "bitbanged" one with the fsl fec driver. > > > > > > Any idea why? > > > > > > Anyway, you should not replicate code, don't copy bitbanging code int= o > > > the FEC. Just use the existing bit-banger MDIO bus master driver. > > > > Right there should be no need for you to modify the FEC driver at all, > > there is an existing generic bitbanged MDIO bus driver here: > > Hi Florian > > Speculation on my part, until i hear back on the Why? question, but > i'm guessing the board has a wrong pullup on the MDIO line. It takes > too long for the PHY/FEC to pull the line low at the default > 2.5MHz. bit-banging is much slower, so it works. > > If i'm right, there is a much simpler fix for this. Use the > clock-frequency property for the MDIO bus to slow the clock down. > > Andrew