From: Adrien Grassein <adrien.grassein@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, DTML <devicetree@vger.kernel.org>,
troy.kisky@boundarydevices.com,
Gary Bisson <gary.bisson@boundarydevices.com>
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add pf8x00 regulator
Date: Thu, 10 Dec 2020 23:24:17 +0100 [thread overview]
Message-ID: <CABkfQAF4AANtxptY+XB2cR6hpz2i2Km+F5U=R67J57zSfnoGMA@mail.gmail.com> (raw)
In-Reply-To: <20201207135551.GE5694@sirena.org.uk>
Hi,
Thanks for reviewing my patches.
Le lun. 7 déc. 2020 à 14:55, Mark Brown <broonie@kernel.org> a écrit :
>
> On Sun, Dec 06, 2020 at 01:26:28AM +0100, Adrien Grassein wrote:
> > Add dt-bindings for the pf8x00 driver.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
>
For v2 I just copy-paste another commit message to be sure to be conform.
> > + compatible:
> > + enum:
> > + - nxp,pf8x00
>
> Compatible strings should be for specific devices not wildcards.
>
> > + nxp,hw-en:
> > + $ref: /schemas/types.yaml#definitions/flag
> > + description: |
> > + Only available for ldo2. Used to enable or disable ld02.
>
> I don't understand what this is documenting - what is "hw-en" and how is
> it used to enable or disable LDO2?
I think I read better documentation for this point. Sorry, it was very unclear.
>
> > + nxp,vselect-en:
> > + $ref: /schemas/types.yaml#definitions/flag
> > + description: |
> > + Only available for ldo2. When specified, use the VSELECT pin
> > + of the chip to control the output voltage of the ldo02 regulator.
>
> Shouldn't there be a GPIO specified somewhere or something so that the
> VSELECT pin can be controlled?
I think I read better documentation for this point. Sorry, it was very unclear.
VSELECT is in fact an input pin of the chip. The configuration just enabled it.
>
> > + nxp,ilim-ma:
> > + $ref: /schemas/types.yaml#definitions/uint32
> > + minimum: 2100
> > + maximum: 4500
> > + default: 2100
> > + enum: [ 2100, 2600, 3000, 4500 ]
> > + description: |
> > + Defines the maximum current delivered by the regulator (in mA).
>
> Is this not a fixed property of the regulator?
It's not. It's configurable by software.
>
> > + nxp,quad-phase:
> > + $ref: /schemas/types.yaml#definitions/flag
> > + description: |
> > + This allow regulators sw1 and sw2, or sw3 and sw4 or sw4 and sw5
> > + to work together to deliver a maximum 10A current.
>
> Presumably this must be set on both the regulators being grouped
> together?
Not. Only the sw1 configuration will be taken in account.
Thanks again,
Adrien
next prev parent reply other threads:[~2020-12-10 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 0:26 [PATCH 1/2] dt-bindings: regulator: Add pf8x00 regulator Adrien Grassein
2020-12-06 0:26 ` [PATCH 2/2] regulator: pf8x00: add support of nxp " Adrien Grassein
2020-12-07 14:08 ` Mark Brown
2020-12-07 20:36 ` kernel test robot
2020-12-07 13:55 ` [PATCH 1/2] dt-bindings: regulator: Add " Mark Brown
2020-12-10 22:24 ` Adrien Grassein [this message]
2020-12-11 13:25 ` Mark Brown
2020-12-10 3:35 ` Rob Herring
2020-12-10 22:16 ` [PATCH v2 1/2] dt-bindings: regulator: add pf8x00 PMIC Adrien Grassein
2020-12-10 22:16 ` [PATCH v2 2/2] regulator: pf8x00: add support of nxp pf8x00 regulator Adrien Grassein
2020-12-11 15:28 ` Mark Brown
2020-12-11 14:04 ` [PATCH v2 1/2] dt-bindings: regulator: add pf8x00 PMIC Mark Brown
2020-12-12 22:43 ` Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABkfQAF4AANtxptY+XB2cR6hpz2i2Km+F5U=R67J57zSfnoGMA@mail.gmail.com' \
--to=adrien.grassein@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.bisson@boundarydevices.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).