From: Junchang Wang <junchangwang@gmail.com>
To: Paul McKenney <paulmck@linux.ibm.com>
Cc: dave@stgolabs.net, josh@joshtriplett.org,
Jonathan Corbet <corbet@lwn.net>,
rostedt@goodmis.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
jiangshanlai@gmail.com, joel@joelfernandes.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] torture.txt: update the list of supported torture types
Date: Wed, 2 Jan 2019 11:48:00 +0800 [thread overview]
Message-ID: <CABoNC82px+072c2eKWcpjMyJX-m8Dh4=L0W6Wxw5Q+HeXoK2Pg@mail.gmail.com> (raw)
In-Reply-To: <20190101175510.GW4170@linux.ibm.com>
On Wed, Jan 2, 2019 at 1:54 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote:
>
> On Tue, Jan 01, 2019 at 10:03:20PM +0800, Junchang Wang wrote:
> > Torture types "rcu_bh" and "sched" were removed in commit "c770c82a23".
> > The name of torture type "rcu_busted" was changed to "busted" in commit
> > "b3c983142d". Two other types, "srcud" and "busted_srcud" were added in
> > commits "ca1d51ed98" and "2397d072f7", respectively. This patch updates
> > torture.txt accordingly.
> >
> > Signed-off-by: Junchang Wang <junchangwang@gmail.com>
>
> Given that this section of this file duplicates the rcutorture kernel boot
> parameters called out in Documentation/admin-guide/kernel-parameters.txt,
> perhaps the best way forward is to instead remove this information from
> Documentation/RCU/torture.txt in favor of a reference to the information
> (with search string) in Documentation/admin-guide/kernel-parameters.txt.
>
> Thoughts?
Hi Paul,
Thanks for the comment; indeed the section "MODULE PARAMETERS" in
torture.txt duplicates the corresponding sections in
kernel-parameters.txt. I can resubmit a patch that (1) removes the
section "MODULE PARAMETERS" in torture.txt, and (2) add a single
sentence saying "Module parameters are detailed in
Documentation/admin-guide/kernel-parameters.txt". Does that sound
good?
Thanks,
--Junchang
>
> Thanx, Paul
>
> > ---
> > Documentation/RCU/torture.txt | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/RCU/torture.txt b/Documentation/RCU/torture.txt
> > index 55918b5..6395f0b 100644
> > --- a/Documentation/RCU/torture.txt
> > +++ b/Documentation/RCU/torture.txt
> > @@ -155,20 +155,19 @@ torture_type The type of RCU to test, with string values as follows:
> > along with expedited, synchronous, and polling
> > variants.
> >
> > - "rcu_bh": rcu_read_lock_bh(), rcu_read_unlock_bh(), and
> > - call_rcu_bh(), along with expedited and synchronous
> > - variants.
> > -
> > - "rcu_busted": This tests an intentionally incorrect version
> > + "busted": This tests an intentionally incorrect version
> > of RCU in order to help test rcutorture itself.
> >
> > "srcu": srcu_read_lock(), srcu_read_unlock() and
> > call_srcu(), along with expedited and
> > synchronous variants.
> >
> > - "sched": preempt_disable(), preempt_enable(), and
> > - call_rcu_sched(), along with expedited,
> > - synchronous, and polling variants.
> > + "srcud": A second form of srcu that dynamically allocates
> > + and frees srcu_struct to test srcu cleanup code path.
> > +
> > + "busted_srcud": This torture type verifies rcutorture's ability
> > + to detect extensions of RCU read-side critical sections
> > + that are not handled.
> >
> > "tasks": voluntary context switch and call_rcu_tasks(),
> > along with expedited and synchronous variants.
> > --
> > 2.7.4
> >
>
next prev parent reply other threads:[~2019-01-02 3:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 14:03 [PATCH 0/2] Documentation/RCU: Update documents Junchang Wang
2019-01-01 14:03 ` [PATCH 1/2] whatisRCU.txt: fix outdated links Junchang Wang
2019-01-01 17:53 ` Paul E. McKenney
2019-01-01 14:03 ` [PATCH 2/2] torture.txt: update the list of supported torture types Junchang Wang
2019-01-01 17:55 ` Paul E. McKenney
2019-01-02 3:48 ` Junchang Wang [this message]
2019-01-02 13:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABoNC82px+072c2eKWcpjMyJX-m8Dh4=L0W6Wxw5Q+HeXoK2Pg@mail.gmail.com' \
--to=junchangwang@gmail.com \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).