linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oskar Senft <osk@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/2] hwmon: (nct7802) Make temperature/voltage sensors configurable
Date: Sat, 9 Oct 2021 23:26:53 -0400	[thread overview]
Message-ID: <CABoTLcS5NJ50Hykizfh842TjZGcT=d0wxMm2-jO4i6wmoDK9Kg@mail.gmail.com> (raw)
In-Reply-To: <638924f2-4323-16d8-5a8b-2afd2b1872d6@roeck-us.net>

Hi Guenter

Thanks again for the review!

> > +     bool found_channel_config = false;
>
> now unused, as 0-day points out.
Argh, I'm so sorry. I don't understand why building this for OpenBMC
didn't flag that up. I thought building with warnings as errors was
now the default? But obviously not :-/

> > +     /* Enable local temperature sensor by default */
> > +     mode_val |= MODE_LTD_EN;
> > +     mode_mask |= MODE_LTD_EN;
> > +
>
> Either make it = and drop the initialization above, or better
> initialize the variables with MODE_LTD_EN right away.
Oh yeah, makes sense. Will do in V6.

Thanks
Oskar.

  reply	other threads:[~2021-10-10  3:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 18:52 [PATCH v5 1/2] dt-bindings: hwmon: Add nct7802 bindings Oskar Senft
2021-10-09 18:52 ` [PATCH v5 2/2] hwmon: (nct7802) Make temperature/voltage sensors configurable Oskar Senft
2021-10-09 18:53   ` Oskar Senft
2021-10-09 22:40   ` kernel test robot
2021-10-09 23:40   ` Guenter Roeck
2021-10-10  3:26     ` Oskar Senft [this message]
2021-10-09 18:53 ` [PATCH v5 1/2] dt-bindings: hwmon: Add nct7802 bindings Oskar Senft
2021-10-09 23:46 ` Guenter Roeck
2021-10-10  3:06   ` Oskar Senft
2021-10-10  4:10     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABoTLcS5NJ50Hykizfh842TjZGcT=d0wxMm2-jO4i6wmoDK9Kg@mail.gmail.com' \
    --to=osk@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).