From: Con Kolivas <kernel@kolivas.org>
To: "Gopal, Saranya" <saranya.gopal@intel.com>
Cc: gregkh@linuxfoundation.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.de>,
felipe.balbi@linux.intel.com
Subject: Re: [PATCH V2] usbcore: Select only first configuration for non-UAC3 compliant devices
Date: Sun, 6 Jan 2019 09:02:05 +1100 [thread overview]
Message-ID: <CABqErrEyF0Fr57gk12_XNNhLdQX0A9b9OPyGeVfGVh1dvHhRrw@mail.gmail.com> (raw)
In-Reply-To: <1546709942-28634-1-git-send-email-saranya.gopal@intel.com>
Hi Saranya
On Sun, 6 Jan 2019 at 04:41, <saranya.gopal@intel.com> wrote:
>
> From: Saranya Gopal <saranya.gopal@intel.com>
>
> In most of the UAC1 and UAC2 audio devices, the first
> configuration is most often the best configuration.
> However, with recent patch to support UAC3 configuration,
> second configuration was unintentionally chosen for
> some of the UAC1/2 devices that had more than one
> configuration. This was because of the existing check
> after the audio config check which selected any config
> which had a non-vendor class. This patch fixes this issue.
>
> Fixes: f13912d3f014 ("usbcore: Select UAC3 configuration for audio if present")
> Reported-by: Con Kolivas <kernel@kolivas.org>
> Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>>
I can confirm the above patch fixes my problem.
Tested-by: Con Kolivas <kernel@kolivas.org>
Thanks!
Con
next prev parent reply other threads:[~2019-01-05 22:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 11:43 ALSA:usb audio Higher sample rates on usb audio no longer working Con Kolivas
2019-01-03 13:23 ` Takashi Iwai
2019-01-03 23:16 ` Con Kolivas
2019-01-04 6:27 ` Takashi Iwai
2019-01-04 15:23 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-04 16:52 ` Gopal, Saranya
2019-01-04 17:13 ` Pierre-Louis Bossart
2019-01-04 20:34 ` Con Kolivas
2019-01-05 14:14 ` Gopal, Saranya
2019-01-05 14:02 ` [PATCH] usbcore: Select only first configuration for non-UAC3 compliant devices saranya.gopal
2019-01-05 14:35 ` Greg KH
2019-01-05 17:39 ` [PATCH V2] " saranya.gopal
2019-01-05 22:02 ` Con Kolivas [this message]
2019-01-06 2:44 ` [PATCH V3] " saranya.gopal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABqErrEyF0Fr57gk12_XNNhLdQX0A9b9OPyGeVfGVh1dvHhRrw@mail.gmail.com \
--to=kernel@kolivas.org \
--cc=alsa-devel@alsa-project.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=saranya.gopal@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).