From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA3AC4363D for ; Fri, 25 Sep 2020 16:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A59321D42 for ; Fri, 25 Sep 2020 16:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NOC83klT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729104AbgIYQpR (ORCPT ); Fri, 25 Sep 2020 12:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727495AbgIYQpR (ORCPT ); Fri, 25 Sep 2020 12:45:17 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63B9FC0613CE; Fri, 25 Sep 2020 09:45:17 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id y14so3052259pgf.12; Fri, 25 Sep 2020 09:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ruCEryVFyAOn3Txfm384BRQUI0WS36tIHI9atsfBz/4=; b=NOC83klTMa/B6Y6Kt6iQ/A5oCUqhE3U6VAb96tggPynZTwJM2eMUu5p4Z7lpPKAoEa HzX4Z0ruwL7YNnauYGynp7rwc1cCrHiDOqjn42iminWT0UhtajgdEfmkP8J+SI0AeSph qaT0GLEuXQCEbNgXXjDTFP9od6z43+v9ZGE4sAnqYH3s4f6oCM2r3MN9Fa7EtKQlt8B1 M998jx/BOxkqJWyOC3L/YpvcDbjvefT8RBs9BOX3k4Q05JGq8q5UuVuJYHOSLrU8KPzk sM24X41y9k7PyGoK7GYsmRN6VW/nq2wmRIK0jH6rAukl+nU1Sb17uLYTWq41pwywp4DE wncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ruCEryVFyAOn3Txfm384BRQUI0WS36tIHI9atsfBz/4=; b=PYdis7zCOfQ6FmHAkX5od4wz7+FSoMEyIPmr2oxjGu7QB13qJbP+oMYVT7VmCpGx2c vAmc5Bj9m1T+8R/OwX1OaYeoM6DP5RBUZEcztBFQkwROpVi6YahQ62mBIYWbOG+rRhoM 99uvmZNDVOY1dQs/mx0XDAJNq7seF0yhqO0rcSapzdl5Sxii1caduYvGv3agNRcP2ht1 kUmqPtS27T4F6H1aLcoprrh1e1q397+2VJ0V/x9H2PXDiWLrgwpHanutXN+3Uu07L6+C xVEkuz6J/npWq1rEKT+kmgKTSzqkXjaizMFfGkfNtTYMnMqYlz3ZdYVacVeHexkXFW7K Nshg== X-Gm-Message-State: AOAM532aGAXN/VZIs+PM9UjDOsQumYCCGUyjwie5LUdHvqIa8rCrtfN+ iF94jeosqea3SdelSVHtSGTLBhhuS2EHIV3AT/M= X-Google-Smtp-Source: ABdhPJyLs9CmSuxL1C3wljdQpenEpIvO5wqWImFZHDW9uWc8lmXcNuFA4qC9zIGeu17/Yl8ddcf0atBt5fqjZbZZZpM= X-Received: by 2002:aa7:9491:0:b029:142:2501:396b with SMTP id z17-20020aa794910000b02901422501396bmr151396pfk.48.1601052316926; Fri, 25 Sep 2020 09:45:16 -0700 (PDT) MIME-Version: 1.0 References: <202009241601.FFC0CF68@keescook> In-Reply-To: From: YiFei Zhu Date: Fri, 25 Sep 2020 11:45:05 -0500 Message-ID: Subject: Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent To: Kees Cook Cc: Linux Containers , YiFei Zhu , bpf , kernel list , Aleksa Sarai , Andrea Arcangeli , Andy Lutomirski , Dimitrios Skarlatos , Giuseppe Scrivano , Hubertus Franke , Jack Chen , Jann Horn , Josep Torrellas , Tianyin Xu , Tobin Feldman-Fitzthum , Tycho Andersen , Valentin Rothberg , Will Drewry Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 10:04 PM YiFei Zhu wrote: > > Why do the prepare here instead of during attach? (And note that it > > should not be written to fail.) > > Right. During attach a spinlock (current->sighand->siglock) is held. Do we really want to put the emulator in the "atomic section"? YiFei Zhu