From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11071C4346E for ; Thu, 24 Sep 2020 07:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF0C23787 for ; Thu, 24 Sep 2020 07:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LQ9fBJUk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbgIXHvd (ORCPT ); Thu, 24 Sep 2020 03:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbgIXHvc (ORCPT ); Thu, 24 Sep 2020 03:51:32 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC90C0613CE; Thu, 24 Sep 2020 00:51:32 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id b124so1363642pfg.13; Thu, 24 Sep 2020 00:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=48nix4rTdQigZRa9Vc7CjTQh3htJMAItDGYGEpyaX94=; b=LQ9fBJUkchQKhpDJK824w+FTNJrBTTwrBKUZD8qpIHSBjtOPhtIzo6VKaoMMHhNFAL lxtHy84Dpu58G96obf8L3Wlh+T+71fNnC8Od/NwficCfZb1+GYjfYw2XDgXjFX8eIQHp 1YiOujXN/CFMVfOoMiIOvcWc3SFrb+s0TAX5ihF2qGNHuxCsqew19roD2DweOQBLVDtI oJxL6FeRwxwgkHl++r4TBYC/gJdE2FOJxlzGFfJv3DJMQs64aAAa26HAOILgU8tv6S8C AIq1mphBEYwZbyzic6qye7YROHHz+2iilIUxfJlFdtlG08D5cGckAo8BUW4KMR9JhLdM rLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=48nix4rTdQigZRa9Vc7CjTQh3htJMAItDGYGEpyaX94=; b=hFXDFZ/+Jj1c88DddS5itIKuRhjVE5Kx6nqmmwMNBLJQWflZEO69ev619gdsXNGNuD v94vxwlbEER56K1l+zrJlqynG8KD1X9OHM0LTerXoBdWb/NlJf1f8gbkTWkrtqb5rqnh pvdsOUqn+8kLzIbYKmMhUuKwcVxv+2gkEPw7d4Iz++GqC1t1SWf0gidrqLQp+v9yHnyZ vRZLS04//OXCfYdS618UhLPXAHmLXAWGDms6jSs4dwHDHROzNEPcFsXxgtR4A38K3Wty BkG3k6wInL1EBwgPWXq4yXJ3kGDIRhHBU68OT0KD+LEr+LPWFOLJlmrb7+d5+nJ5UHRV phYw== X-Gm-Message-State: AOAM530lqevAecA1YrYEn6m7yLbquVz9D8jamKPR/BWYZSkAQP9dV32A pL+ed0m/oqQTMPc+NIopUekidsrFAynsgV1TGnGYB0sSBm3tVg== X-Google-Smtp-Source: ABdhPJx65pp+0WKMk7ffwPmRtbbQTqLX1EOoTsZNPeH430NNbFVserZlspAwXhx3O3RcBnCwjUoE6+jE3pvHXX1gUQg= X-Received: by 2002:a63:511d:: with SMTP id f29mr3010937pgb.11.1600933891983; Thu, 24 Sep 2020 00:51:31 -0700 (PDT) MIME-Version: 1.0 References: <20200923232923.3142503-1-keescook@chromium.org> <20200923232923.3142503-4-keescook@chromium.org> <202009240037.21A9E3CE@keescook> In-Reply-To: <202009240037.21A9E3CE@keescook> From: YiFei Zhu Date: Thu, 24 Sep 2020 02:51:20 -0500 Message-ID: Subject: Re: [PATCH 3/6] seccomp: Implement constant action bitmaps To: Kees Cook Cc: Jann Horn , Christian Brauner , Tycho Andersen , Andy Lutomirski , Will Drewry , Andrea Arcangeli , Giuseppe Scrivano , Tobin Feldman-Fitzthum , Dimitrios Skarlatos , Valentin Rothberg , Hubertus Franke , bpf , Linux Containers , linux-api@vger.kernel.org, kernel list , Jack Chen , Josep Torrellas , Tianyin Xu , YiFei Zhu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 2:38 AM Kees Cook wrote: > > Would you mind educating me how this patch plan one handling MIPS? For > > one kernel they seem to have up to three arch numbers per build, > > AUDIT_ARCH_MIPS{,64,64N32}. Though ARCH_TRACE_IGNORE_COMPAT_SYSCALLS > > does not seem to be defined for MIPS so I'm assuming the syscall > > numbers are the same, but I think it is possible some client uses that > > arch number to pose different constraints for different processes, so > > it would better not accelerate them rather than break them. > > I'll take a look, but I'm hoping it won't be too hard to fit into what > I've got designed so for to deal with x86_x32. (Will MIPS want this > optimization at all?) I just took a slightly closer look at MIPS and it seems that they have sparse syscall numbers (defines HAVE_SPARSE_SYSCALL_NR). I don't know how the different "regions of syscall numbers" are affected by arch numbers, however...