From: ChiaEn Wu <peterwu.pub@gmail.com>
To: Joe Simmons-Talbott <joetalbott@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sre@kernel.org, chunfeng.yun@mediatek.com,
gregkh@linuxfoundation.org, Jonathan Cameron <jic23@kernel.org>,
lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org,
linux@roeck-us.net, heikki.krogerus@linux.intel.com,
deller@gmx.de, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
ChiYuan Huang <cy_huang@richtek.com>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org,
szunichen@gmail.com
Subject: Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight
Date: Fri, 24 Jun 2022 17:34:36 +0800 [thread overview]
Message-ID: <CABtFH5JdPHfvGi+tG+EKh_-XH0YxWHR3o=LsPAdW38e8fFoBeg@mail.gmail.com> (raw)
In-Reply-To: <YrRny9TPqMUW7Yr/@spruce>
Hi Joe,
Joe Simmons-Talbott <joetalbott@gmail.com> 於 2022年6月23日 週四 晚上9:17寫道:
>
> On Thu, Jun 23, 2022 at 07:56:22PM +0800, ChiaEn Wu wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add mt6370 backlight binding documentation.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> >
> > v3
> > - Rename "mediatek,bled-pwm-hys-input-threshold-steps" to
> > "mediatek,bled-pwm-hys-input-th-steps"
> > - Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt",
> > "bled-ocp-microamp" enum values
> > ---
> > .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++
> > 1 file changed, 92 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> > new file mode 100644
> > index 0000000..26563ae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> > @@ -0,0 +1,92 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT6370 Backlight
> > +
> > +maintainers:
> > + - ChiaEn Wu <chiaen_wu@richtek.com>
> > +
> > +description: |
> > + This module is part of the MT6370 MFD device.
> > + The MT6370 Backlight WLED driver supports up to a 29V output voltage for
> > + 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
> > + capability with 2048 current steps (11 bits) in exponential or linear
> > + mapping curves.
> > +
> > +allOf:
> > + - $ref: common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6370-backlight
> > +
> > + default-brightness:
> > + minimum: 0
> > + maximum: 2048
> > +
> > + max-brightness:
> > + minimum: 0
> > + maximum: 2048
> > +
> > + enable-gpios:
> > + description: External backlight 'enable' pin
> > + maxItems: 1
> > +
> > + mediatek,bled-pwm-enable:
> > + description: |
> > + Enable external PWM input for backlight dimming
> > + type: boolean
> > +
> > + mediatek,bled-pwm-hys-enable:
> > + description: |
> > + Enable the backlight input-hysteresis for PWM mode
> > + type: boolean
> > +
> > + mediatek,bled-pwm-hys-input-th-steps:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + enum: [1, 4, 16, 64]
> > + description: |
> > + The selection of the upper and lower bounds threshold of backlight
> > + PWM resolution. If we choose selection 64, the variation of PWM
> > + resolution needs over than 64 steps.
>
> more than?
>
> Thanks,
> Joe
>
Thanks for your helpful comments!
I will revise this in the next patch. Thanks!
> > +
> > + mediatek,bled-ovp-shutdown:
> > + description: |
> > + Enable the backlight shutdown when OVP level triggered
> > + type: boolean
> > +
> > + mediatek,bled-ovp-microvolt:
> > + enum: [17000000, 21000000, 25000000, 29000000]
> > + description: |
> > + Backlight OVP level selection.
> > +
> > + mediatek,bled-ocp-shutdown:
> > + description: |
> > + Enable the backlight shutdown when OCP level triggerred.
> > + type: boolean
> > +
> > + mediatek,bled-ocp-microamp:
> > + enum: [900000, 1200000, 1500000, 1800000]
> > + description: |
> > + Backlight OC level selection.
> > +
> > + mediatek,bled-channel-use:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + description: |
> > + Backlight LED channel to be used.
> > + Each bit mapping to:
> > + - 0: CH4
> > + - 1: CH3
> > + - 2: CH2
> > + - 3: CH1
> > + minimum: 1
> > + maximum: 15
> > +
> > +required:
> > + - compatible
> > + - mediatek,bled-channel-use
> > +
> > +additionalProperties: false
> > --
> > 2.7.4
> >
Best regards,
ChiaEn Wu
next prev parent reply other threads:[~2022-06-24 9:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 11:56 [PATCH v3 00/14] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 01/14] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-06-24 10:27 ` Krzysztof Kozlowski
2022-06-25 0:54 ` Miles Chen
2022-06-23 11:56 ` [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-06-24 10:35 ` Krzysztof Kozlowski
2022-06-24 10:45 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 04/14] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-06-24 11:22 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-06-23 13:16 ` Joe Simmons-Talbott
2022-06-24 9:34 ` ChiaEn Wu [this message]
2022-06-30 21:55 ` Rob Herring
2022-06-23 11:56 ` [PATCH v3 06/14] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-06-24 11:39 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 18:00 ` Andy Shevchenko
2022-06-24 10:19 ` ChiaEn Wu
2022-06-28 11:52 ` Andy Shevchenko
2022-07-12 15:29 ` Lee Jones
2022-07-13 2:29 ` ChiaEn Wu
2022-07-13 8:04 ` Lee Jones
2022-07-13 9:31 ` ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-06-23 18:07 ` Andy Shevchenko
2022-06-24 11:33 ` Greg KH
2022-06-23 11:56 ` [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-06-23 18:18 ` Andy Shevchenko
2022-06-24 10:32 ` ChiaEn Wu
2022-06-28 11:54 ` Andy Shevchenko
2022-06-23 11:56 ` [PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 18:25 ` Andy Shevchenko
2022-06-23 11:56 ` [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-06-23 18:56 ` Andy Shevchenko
2022-06-29 15:52 ` ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-06-23 19:29 ` Randy Dunlap
2022-06-24 6:23 ` Linus Walleij
2022-06-24 6:25 ` Linus Walleij
2022-06-24 7:20 ` szuni chen
2022-06-24 21:36 ` Linus Walleij
2022-06-23 11:56 ` [PATCH v3 13/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 13:43 ` Daniel Thompson
2022-06-24 9:56 ` ChiaEn Wu
2022-06-23 15:48 ` (subset) [PATCH v3 00/14] Add Mediatek MT6370 PMIC support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABtFH5JdPHfvGi+tG+EKh_-XH0YxWHR3o=LsPAdW38e8fFoBeg@mail.gmail.com' \
--to=peterwu.pub@gmail.com \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=joetalbott@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).