From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mike Turquette <mturquette@linaro.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Emilio Lopez <emilio@elopez.com.ar>
Subject: Re: [PATCH] of: pass name argument for of_io_request_and_map as const char *
Date: Thu, 13 Nov 2014 10:04:04 +0100 [thread overview]
Message-ID: <CABuKBe+vRJUk1fB2mwUzGnnVcS-3N9U2uwgW1ZFwKBOe5sWf0Q@mail.gmail.com> (raw)
In-Reply-To: <1415816222-32200-1-git-send-email-wens@csie.org>
I already send a patch for that which got accepted by Grant [0].
Although right now, I'm not able to find it on his repository [1].
Cheers,
Matthias
[0] https://lkml.org/lkml/2014/11/4/588
[1] https://git.kernel.org/cgit/linux/kernel/git/glikely/linux.git/
2014-11-12 19:17 GMT+01:00 Chen-Yu Tsai <wens@csie.org>:
> The name argument for of_io_request_and_map is only passed to
> request_mem_region, which is a macro of __request_region, which
> takes a const name argument.
>
> Make the name argument const, so when we pass const strings we
> don't get the following warnings:
>
> warning: passing argument 3 of 'of_io_request_and_map' discards
> 'const' qualifier from pointer target type [enabled by default]
>
> In file included from drivers/clk/sunxi/clk-sunxi.c:20:0:
> include/linux/of_address.h:108:15: note: expected 'char *' but
> argument is of type 'const char *'
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> I ran into this while switching some of the sunxi clock code to use
> of_io_request_and_map.
>
> ---
> drivers/of/address.c | 2 +-
> include/linux/of_address.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index afdb782..e02828f 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -871,7 +871,7 @@ EXPORT_SYMBOL(of_iomap);
> * return PTR_ERR(base);
> */
> void __iomem *of_io_request_and_map(struct device_node *np, int index,
> - char *name)
> + const char *name)
> {
> struct resource res;
> void __iomem *mem;
> diff --git a/include/linux/of_address.h b/include/linux/of_address.h
> index 8cb14eb..d88e81b 100644
> --- a/include/linux/of_address.h
> +++ b/include/linux/of_address.h
> @@ -106,7 +106,7 @@ extern int of_address_to_resource(struct device_node *dev, int index,
> struct resource *r);
> void __iomem *of_iomap(struct device_node *node, int index);
> void __iomem *of_io_request_and_map(struct device_node *device,
> - int index, char *name);
> + int index, const char *name);
> #else
>
> #include <linux/io.h>
> @@ -123,7 +123,7 @@ static inline void __iomem *of_iomap(struct device_node *device, int index)
> }
>
> static inline void __iomem *of_io_request_and_map(struct device_node *device,
> - int index, char *name)
> + int index, const char *name)
> {
> return IOMEM_ERR_PTR(-EINVAL);
> }
> --
> 2.1.3
>
--
motzblog.wordpress.com
next prev parent reply other threads:[~2014-11-13 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 18:17 [PATCH] of: pass name argument for of_io_request_and_map as const char * Chen-Yu Tsai
2014-11-13 9:04 ` Matthias Brugger [this message]
2014-11-13 18:56 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABuKBe+vRJUk1fB2mwUzGnnVcS-3N9U2uwgW1ZFwKBOe5sWf0Q@mail.gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).