From: Javier Martinez Canillas <javier@dowhile0.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: am335x-boneblack: Use pinctrl constants and AM33XX_IOPAD macro
Date: Tue, 27 Oct 2015 09:24:44 +0900 [thread overview]
Message-ID: <CABxcv==KtL_XBd7pKMipU+BUjX7dOFTXA59vh+_No5eiXCKXJw@mail.gmail.com> (raw)
In-Reply-To: <1445706313-14761-1-git-send-email-afd@ti.com>
Hello Andrew,
On Sun, Oct 25, 2015 at 2:05 AM, Andrew F. Davis <afd@ti.com> wrote:
> Using constants for pinctrl allows better readability and removes
> redundancy with comments. AM33XX_IOPAD allows us to use part of the
> pinctrl physical address as in the TRM instead of an offset.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
I haven't verified the values against the TRM, but assuming there are correct:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
Javier
next prev parent reply other threads:[~2015-10-27 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 17:05 [PATCH v2] ARM: dts: am335x-boneblack: Use pinctrl constants and AM33XX_IOPAD macro Andrew F. Davis
2015-10-27 0:24 ` Javier Martinez Canillas [this message]
2015-11-10 18:28 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv==KtL_XBd7pKMipU+BUjX7dOFTXA59vh+_No5eiXCKXJw@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=afd@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).