From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbcFJSyp (ORCPT ); Fri, 10 Jun 2016 14:54:45 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:33740 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbcFJSyn (ORCPT ); Fri, 10 Jun 2016 14:54:43 -0400 MIME-Version: 1.0 X-Originating-IP: [201.217.58.84] In-Reply-To: <59c49951b95b0eb5b34eede6cfce526e72bc2443.1465486875.git.peter.senna@collabora.com> References: <1464626385-19253-1-git-send-email-peter.senna@collabora.com> <59c49951b95b0eb5b34eede6cfce526e72bc2443.1465486875.git.peter.senna@collabora.com> Date: Fri, 10 Jun 2016 14:54:42 -0400 Message-ID: Subject: Re: [PATCH V2 3/5] Documentation/devicetree/bindings: b850v3_lvds_dp From: Javier Martinez Canillas To: Peter Senna Tschudin Cc: David Airlie , akpm , "David S. Miller" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Enric Balletbo i Serra , Enric Balletbo Serra , Kumar Gala , Greg Kroah-Hartman , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Ian Campbell , jslaby@suse.cz, Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , linux@armlinux.org.uk, Linux Kernel , Guenter Roeck , Mark Rutland , martin.donnelly@ge.com, martyn.welch@collabora.co.uk, Mauro Carvalho Chehab , Pawel Moll , peter.senna@gmail.com, p.zabel@pengutronix.de, Thierry Reding , rmk+kernel@armlinux.org.uk, Rob Herring , shawnguo@kernel.org, tiwai@suse.com, Thierry Reding , ykk@rock-chips.com, Fabio Estevam Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Peter, On Thu, Jun 9, 2016 at 12:25 PM, Peter Senna Tschudin wrote: > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > display bridge. > > Cc: Enric Balletbo i Serra > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Fabio Estevam > Signed-off-by: Peter Senna Tschudin > --- > Changes from V1: > - Replaced '_' by '-' in node names or compatible strings > - Added missing @73 to the example > > .../devicetree/bindings/ge/b850v3_lvds_dp.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt > > diff --git a/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt > new file mode 100644 > index 0000000..46bbea9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt > @@ -0,0 +1,38 @@ > +Driver for GE B850v3 LVDS/DP++ display bridge > + > +Required properties: > + - compatible : should be "ge,b850v3_lvds_dp". It seems you forgot to replace '_' by '-' (you did in the example though) > + - reg : should contain the address used to ack the interrupts. > + - interrupt-parent : should link to the gpio used as interrupt > + source on the host. Is the interrupt parent always a GPIO controller since that is what this description says. Shouldn't be instead something like instead? interrupt-parent: phandle of the interrupt controller that services interrupts to the device > + - interrupts : one interrupt should be described here, as in > + <0 IRQ_TYPE_LEVEL_HIGH>. > + - edid-reg : should contain the address used to read edid information > + - port : should describe the vide signal connection between the host s/vide/video > + and the bridge. > + > +Example: > + > +&mux2_i2c2 { > + status = "okay"; > + clock-frequency = <100000>; > + > + b850v3-lvds-dp-bridge@73 { > + compatible = "ge,b850v3-lvds-dp"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x73>; > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + > + edid-reg = <0x72>; > + > + port@0 { > + reg = <0>; AFAIU a unit-address and reg property for ports are only needed if you have more than one port according to Documentation/devicetree/bindings/graph.txt and Documentation/devicetree/bindings/media/video-interfaces.txt. > + b850v3_dp_bridge_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + }; > +}; > -- Best regards, Javier