From: Javier Martinez Canillas <javier@dowhile0.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Hector Martin <marcan@marcan.st>, David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen
Date: Tue, 30 Nov 2021 10:31:52 +0100 [thread overview]
Message-ID: <CABxcv=kWa8ghQkVeKFN+emQ1wRV=AErULVr9E6R3ZBBiCkMxcw@mail.gmail.com> (raw)
In-Reply-To: <9315c6f5-48f6-4f29-1e31-87ab5ed771b5@suse.de>
Hello Thomas,
On Tue, Nov 30, 2021 at 9:31 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 30.11.21 um 07:44 schrieb Javier Martinez Canillas:
[snip]
> >
> > I think that instead it could be done in the sysfb_create_simplefb()
> > function [0], which already creates the "simple-framebuffer" device
> > for x86 legacy BIOS and x86/arm64/riscv EFI so it makes sense to do
> > the same for OF. That way the simplefb platform device registration
> > code could also be dropped from the driver and users would just need
> > to enable CONFIG_SYSFB and CONFIG_SYSFB_SIMPLEFB to have the same.
> >
> > I have a couple of boards with a bootloader that populates a
> > "simple-framebuffer" in the /chosen node so I could attempt to write
> > the patches. But probably won't happen until next week.
>
> IMHO it's better to keep the OF-related setup in the OF code. The sysfb
> code is for screen_info. We can try to find common code for OF and sysfb
> that then lives in a shared location.
>
Ok. As long as we don't end with code duplication then that works for me too.
> Using a single global screen_info variable is somewhat awkward these
> days. In the long term, I can think of pushing sysfb code into
> architectures. Each architecture would then setup the platform devices
> that it supports. But that's not really important right now.
>
That makes sense. And provide a set of helpers as you mentioned that could
be shared across the different architectures and firmware interfaces.
Best regards,
Javier
next prev parent reply other threads:[~2021-11-30 9:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:58 [PATCH 0/3] drm/simpledrm: Apple M1 / DT platform support fixes Hector Martin
2021-11-17 14:58 ` [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen Hector Martin
2021-11-18 9:19 ` Thomas Zimmermann
2021-11-20 3:23 ` Hector Martin
2021-11-29 11:26 ` Thomas Zimmermann
2021-11-29 19:29 ` Rob Herring
2021-11-30 6:44 ` Javier Martinez Canillas
2021-11-30 8:31 ` Thomas Zimmermann
2021-11-30 9:31 ` Javier Martinez Canillas [this message]
2021-11-30 18:25 ` Rob Herring
2021-11-17 14:58 ` [PATCH 2/3] drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_dstclip() Hector Martin
2021-11-18 9:16 ` Thomas Zimmermann
2021-11-22 9:52 ` Pekka Paalanen
2021-11-22 10:05 ` Hector Martin
2021-11-22 10:39 ` Pekka Paalanen
2021-11-17 14:58 ` [PATCH 3/3] drm/simpledrm: Enable XRGB2101010 format Hector Martin
2021-11-18 9:16 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv=kWa8ghQkVeKFN+emQ1wRV=AErULVr9E6R3ZBBiCkMxcw@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=airlied@linux.ie \
--cc=alyssa@rosenzweig.io \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).