From: Javier Martinez Canillas <javier@dowhile0.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Thierry Reding" <treding@nvidia.com>,
"Alexandru Stan" <amstan@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Brian Norris" <briannorris@chromium.org>,
"Douglas Anderson" <dianders@chromium.org>,
naobsd@gmail.com, "Linux Kernel" <linux-kernel@vger.kernel.org>,
linux-rockchip@lists.infradead.org,
"Sjoerd Simons" <sjoerd.simons@collabora.co.uk>,
mbrugger@suse.com, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
p.zabel@pengutronix.de, "Olof Johansson" <olof@lixom.net>,
andy.yan@rock-chips.com, romain.perier@gmail.com,
jic23@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add basic support for orion-r68
Date: Fri, 15 Jan 2016 10:28:44 -0300 [thread overview]
Message-ID: <CABxcv=m+hK3xS8_fYNns-xE5DaLHD0D_Yj8McjM72Y_5V=YmSw@mail.gmail.com> (raw)
In-Reply-To: <1452863192-29231-2-git-send-email-matthias.bgg@gmail.com>
Hello Matthias,
This is not a complete review but I just wanted to comment on two
things that I noticed:
On Fri, Jan 15, 2016 at 10:06 AM, Matthias Brugger
<matthias.bgg@gmail.com> wrote:
[snip]
> + };
> +
> + vcc_18: vcc18-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_18";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_sys>;
> + };
> +
> + /* supplies both host and otg */
> + vcc_host: vcc-host-regulator {
> + compatible = "regulator-fixed";
> + gpio = <&gpio0 4 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&host_vbus_drv>;
> + regulator-name = "vcc_host";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_sys>;
> + };
> +
> + vccio_sd: vcc-io-sd-regulator {
> + regulator-name= "vccio_sd";
> + gpio = <&gpio0 9 GPIO_ACTIVE_LOW>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + vcc_sd: vcc-sd-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_sd";
> + gpio = <&gpio3 11 GPIO_ACTIVE_LOW>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_io>;
> + };
> +
> + vcc_io: vcc-io-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_io";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_sys>;
> + };
> +
> + vcc_lan: vcc-lan-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_lan";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_io>;
> + };
> +
> + vcc_sys: vcc-sys-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_sys";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vccio_wl: vccio-wl-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vccio_wl";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_io>;
> + };
> +
> + vdd_10: vdd-10-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_10";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <&vcc_sys>;
> + };
> +};
There is only one regulator that is not marked as always-on. This will
prevent the regulator subsystem to disable unused regulators. Do you
really need all of them to be always-on?
> +
> +&emmc {
> + broken-cd;
> + bus-width = <8>;
> + cap-mmc-highspeed;
> + disable-wp;
> + mmc-pwrseq = <&emmc_pwrseq>;
> + non-removable;
Non-removable assumes always present so there is no need for
broken-cd. In fact, these two properties are mutually exclusive
according to Documentation/devicetree/bindings/mmc/mmc.txt.
Best regards,
Javier
next prev parent reply other threads:[~2016-01-15 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 13:06 [PATCH 1/2] devicetree: bindings: Add vendor prefix for Tronsmart Matthias Brugger
2016-01-15 13:06 ` [PATCH 2/2] arm64: dts: rockchip: Add basic support for orion-r68 Matthias Brugger
2016-01-15 13:28 ` Javier Martinez Canillas [this message]
2016-01-15 14:03 ` Heiko Stuebner
2016-01-15 14:22 ` Javier Martinez Canillas
2016-01-15 14:26 ` Heiko Stuebner
2016-01-15 15:31 ` Javier Martinez Canillas
2016-01-15 14:21 ` Mark Rutland
2016-01-16 1:22 ` Naoki FUKAUMI
2016-01-17 0:17 ` [PATCH 1/2] devicetree: bindings: Add vendor prefix for Tronsmart Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv=m+hK3xS8_fYNns-xE5DaLHD0D_Yj8McjM72Y_5V=YmSw@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=amstan@chromium.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=naobsd@gmail.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@gmail.com \
--cc=sjoerd.simons@collabora.co.uk \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).