From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbbBPLJq (ORCPT ); Mon, 16 Feb 2015 06:09:46 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:42485 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755506AbbBPLJo (ORCPT ); Mon, 16 Feb 2015 06:09:44 -0500 MIME-Version: 1.0 X-Originating-IP: [95.23.58.121] In-Reply-To: <54E184B6.90808@samsung.com> References: <1423828368-18456-1-git-send-email-addy.ke@rock-chips.com> <1423894668-8886-1-git-send-email-addy.ke@rock-chips.com> <54E184B6.90808@samsung.com> Date: Mon, 16 Feb 2015 12:09:43 +0100 Message-ID: Subject: Re: [PATCH v4 0/3] about data busy From: Javier Martinez Canillas To: Jaehoon Chung Cc: Addy Ke , Ulf Hansson , Olof Johansson , Alim Akhtar , Andrzej Hajda , Douglas Anderson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , cf@rock-chips.com, lintao@rock-chips.com, huangtao@rock-chips.com, Linux Kernel , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jaehoon, On Mon, Feb 16, 2015 at 6:48 AM, Jaehoon Chung wrote: > On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote: >> I modified [1] your patch #2 to do what Alim suggested and only with >> that patch on top of linux-next I have neither the the "Timeout >> sending command" error nor the uSD not getting detected errors. Linux >> mounts the rootfs from the uSD and the wifi SDIO device is enumerated >> and listed in /sys/bus/sdio/devices/ > > it needs to check when clock value only update. > As Javier and Alim are mentioned, if check whether card is busy or not in setup_bus(), > should be processed unnecessary checking. > (According to TRM, before disabling clock, check whether card is busy or not.) > if my thinking is right, chekcing is located more exactly before mci_writel(host, CLKENA, 0). > > And i recommend if CLK_GATE is enabled, clkgate_delay sets to the bigger value than 3. > I'm not sure Javier's issue is same thing..I will check more this. > Thanks for checking, do you have access to a Peach Pit or Pi Chromebook to reproduce the issue I reported? Please let me know if you need any help from me. > Best Regards, > Jaehoon Chung > Best regards, Javier