From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbbCaGne (ORCPT ); Tue, 31 Mar 2015 02:43:34 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34922 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbCaGnc (ORCPT ); Tue, 31 Mar 2015 02:43:32 -0400 MIME-Version: 1.0 X-Originating-IP: [95.23.56.200] In-Reply-To: <5519DE76.4080803@samsung.com> References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> <5519DE76.4080803@samsung.com> Date: Tue, 31 Mar 2015 08:43:30 +0200 Message-ID: Subject: Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc From: Javier Martinez Canillas To: Chanwoo Choi Cc: Krzysztof Kozlowski , Kukjin Kim , Alessandro Zummo , "devicetree@vger.kernel.org" , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , rtc-linux@googlegroups.com, Alexandre Belloni , Kyungmin Park Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 1:38 AM, Chanwoo Choi wrote: > On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote: >> Mark "samsung,exynos3250-rtc" compatible as deprecated because it >> duplicates the "samsung,s3c6410-rtc". Use "samsung,s3c6410-rtc" on >> Exynos3250 and Exynos4415 boards. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 3 ++- >> arch/arm/boot/dts/exynos3250.dtsi | 2 +- >> arch/arm/boot/dts/exynos4415.dtsi | 2 +- >> 3 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >> index ab757b84daa7..ac2fcd6ff4b8 100644 >> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt >> @@ -6,7 +6,8 @@ Required properties: >> * "samsung,s3c2416-rtc" - for controllers compatible with s3c2416 rtc. >> * "samsung,s3c2443-rtc" - for controllers compatible with s3c2443 rtc. >> * "samsung,s3c6410-rtc" - for controllers compatible with s3c6410 rtc. >> - * "samsung,exynos3250-rtc" - for controllers compatible with exynos3250 rtc. >> + * "samsung,exynos3250-rtc" - (deprecated) for controllers compatible with >> + exynos3250 rtc (use "samsung,s3c6410-rtc"). >> - reg: physical base address of the controller and length of memory mapped >> region. >> - interrupts: Two interrupt numbers to the cpu should be specified. First >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index e3bfb11c6ef8..8d58b550e925 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -189,7 +189,7 @@ >> }; >> >> rtc: rtc@10070000 { >> - compatible = "samsung,exynos3250-rtc"; >> + compatible = "samsung,s3c6410-rtc"; >> reg = <0x10070000 0x100>; >> interrupts = <0 73 0>, <0 74 0>; >> interrupt-parent = <&pmu_system_controller>; >> diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi >> index 5caea996e090..186cb8465683 100644 >> --- a/arch/arm/boot/dts/exynos4415.dtsi >> +++ b/arch/arm/boot/dts/exynos4415.dtsi >> @@ -177,7 +177,7 @@ >> }; >> >> rtc: rtc@10070000 { >> - compatible = "samsung,exynos3250-rtc"; >> + compatible = "samsung,s3c6410-rtc"; >> reg = <0x10070000 0x100>; >> interrupts = <0 73 0>, <0 74 0>; >> status = "disabled"; >> > > Looks good to me. > > Reviewed-by: Chanwoo Choi > > Thanks, > Chanwoo Choi > -- Looks good to me also. Reviewed-by: Javier Martinez Canillas Best regards, Javier