From: Martin Nordholts <enselic@gmail.com>
To: Benson Leung <bleung@chromium.org>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
Olof Johansson <olof@lixom.net>,
Yufeng Shen <miletus@chromium.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race
Date: Mon, 5 Aug 2013 07:32:43 +0200 [thread overview]
Message-ID: <CAC-DJzL0VzDxCpsdwjugavBhcFUr+kv+iN9D-Yz_tasw=DF75Q@mail.gmail.com> (raw)
In-Reply-To: <CANLzEksSsMY2pTYTfGzgntF-i_Kus+WeVPyNzW0U7APcGOv_5g@mail.gmail.com>
2013/8/5 Benson Leung <bleung@chromium.org>:
> Hi Martin,
>
> Thank you for looking into this problem. Obviously, this is a problem
> Olof and our team has been working on as well.
Hi Benson,
Thank you for spending time reviewing and testing my patch. I
understand your team is busy and am honored you took the time to look
at my code.
> Your driver would result in three failed probes in 2 different drivers
> on my board.
Yes that is one down-side; sometimes the detect() function will be
triggered even though the device is not supported (the return -ENODEV
code paths in my driver). I thought that maybe a simpler driver could
make up for unnecessary detect() calls. However ...
> "Detect" is method #3, but it comes with a
> stern warning : Once again, method 3 should be avoided wherever
> possible. Explicit device instantiation (methods 1 and 2) is much
> preferred for it is safer and faster.
... I must admit I did not see this. I realize that this makes my
patch a dead end. I wish I would have seen that earlier, that would
have saved time for everyone. My apologies.
Regarding the interaction with non-i2c devices in chromeos_laptop, I
was thinking that could perhaps have been solved by putting the i2c
stuff in a separate driver, say chromeos_laptop_i2c, but that point is
irrelevant now that you pointed out that the use of the
detect()-method is discouraged by the documentation.
Thank you again for reviewing the patch and for providing feedback.
BR,
Martin
next prev parent reply other threads:[~2013-08-05 5:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 15:58 [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race enselic
2013-07-18 15:58 ` [PATCH 1/1] " enselic
2013-08-05 3:52 ` [PATCH 0/1] " Benson Leung
2013-08-05 5:32 ` Martin Nordholts [this message]
2013-08-07 21:55 ` Benson Leung
2013-08-11 19:54 ` Martin Nordholts
2013-08-11 22:44 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC-DJzL0VzDxCpsdwjugavBhcFUr+kv+iN9D-Yz_tasw=DF75Q@mail.gmail.com' \
--to=enselic@gmail.com \
--cc=bleung@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=miletus@chromium.org \
--cc=olof@lixom.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).