From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFD1C433E0 for ; Fri, 29 Jan 2021 01:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3C1164DF1 for ; Fri, 29 Jan 2021 01:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbhA2B34 (ORCPT ); Thu, 28 Jan 2021 20:29:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbhA2B3y (ORCPT ); Thu, 28 Jan 2021 20:29:54 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7DD4C061573; Thu, 28 Jan 2021 17:29:13 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id f1so10273156lfu.3; Thu, 28 Jan 2021 17:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9a+7oNJRCxFrNJOqccL2faO5Eau0vb9fXtZnpOrkLR0=; b=uPaqFT+3ZinDnW0ZgrzxVvIw+T4jYGaYOoHuLoKvr35YYy7OiroCIP7vXFFT69vGNx Anz9afbM6uJDpeZqGmDCDDIQeS6EozPlHfFxAeZmNritl8ftD2kgrffvA/XP8maaRnzm oMDba7gvxsbRmC64c9Ut0cJwaC9MSb0vTxrsu4y78C1iaHMnIBGCuDJzOUKoHL+B2wO4 8cJX8DMPfnpBbdBk7linybIhK2rGv2cjt/0O+CqpLwjQwtYyBlCtvxmEDm1+axhQZRSm /BcEefd/KoicVDmX85wfNgKe9rAf7jJ3hDIR//z98gJi27uj6UCpuCpqlVP6PHK+GwHY 3dHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9a+7oNJRCxFrNJOqccL2faO5Eau0vb9fXtZnpOrkLR0=; b=ovWDWpN2JH3nTsBwYibu82fXWSL8YScJeG1xUwaYyf9be2YbLhCl3PgpB5XTmTbKwq HnMr9r6/61muXTyFiuldF993dL38vdZSqgIvEwJRjqlqeb/7tT5ccDhH6oqg/UjtIpK2 D0d+gftgBJzOZyQ1yRwuqS9bs+z5NBE59nZlY4yIK0OZ1hIo4bCoh0qoc9JIFWmjU2q+ bBnKqLGlK0mItKtNolSVOT/oQ/NzQwXk13eRpz6FvWXJOkTHG0ZrUiQtuYfCPM3XRdzH fo0kjAlatBqs298Kr0rihBXDHxgtDBEwqQdYV3wImGRxX5wySeID6cguTLujp3jgHKxy Hsaw== X-Gm-Message-State: AOAM531Bql2yHrtL2MlnOFoMzDyvVGTilrCS9yFtu3ThotywSrrpioKG y/ElLmIzJRAqluwvhjs4aXQJ8rvQAiKi46CJtGk= X-Google-Smtp-Source: ABdhPJwk+wTmFlhGzF/8Wq5stBatXQi5ZhZ4CiifprtDNeB9IAWTFKszWobd5Q09hqhvxkEoXYuHk0ZLov9FU/+O7OQ= X-Received: by 2002:ac2:44b1:: with SMTP id c17mr829844lfm.556.1611883752325; Thu, 28 Jan 2021 17:29:12 -0800 (PST) MIME-Version: 1.0 References: <20210126072443.33066-1-foxhlchen@gmail.com> <87zh0tg1bn.fsf@notabene.neil.brown.name> In-Reply-To: <87zh0tg1bn.fsf@notabene.neil.brown.name> From: Fox Chen Date: Fri, 29 Jan 2021 09:29:00 +0800 Message-ID: Subject: Re: [PATCH 00/12] docs: path-lookup: Update pathlookup docs To: NeilBrown Cc: Jonathan Corbet , vegard.nossum@oracle.com, Al Viro , rdunlap@infradead.org, grandmaster@al2klimov.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 11:58 AM NeilBrown wrote: > > On Tue, Jan 26 2021, Fox Chen wrote: > > > The Path lookup is a very complex subject in VFS. The path-lookup > > document provides a very detailed guidance to help people understand > > how path lookup works in the kernel.This document was originally > > written based on three lwn articles five years ago. As times goes by, > > some of the content was outdated. This patchset is intended to update > > the document to make it more relevant to current codebase. > > > > > > Fox Chen (12): > > docs: path-lookup: update follow_managed() part > > docs: path-lookup: update path_to_nameidata() parth > > docs: path-lookup: update path_mountpoint() part > > docs: path-lookup: update do_last() part > > docs: path-lookup: remove filename_mountpoint > > docs: path-lookup: Add macro name to symlink limit description > > docs: path-lookup: i_op->follow_link replaced with i_op->get_link > > docs: path-lookup: update i_op->put_link and cookie description > > docs: path-lookup: no get_link() > > docs: path-lookup: update WALK_GET, WALK_PUT desc > > docs: path-lookup: update get_link() ->follow_link description > > docs: path-lookup: update symlink description > > > > Thanks for doing this. I've responded individually to several of the > patches. As you can see from my comments, there is often more to it > than just changing function names. In some places you have capture the > more general nature of the change fairly well. In other places the > result is incoherent or confusion. > Making small updates to this sort of documentation is not easy. You > need to step have and see the "big picture", to overall story-arc. > Sometimes you can fit changes into that arc, sometimes you might need to > restructure or re-tell the story. > > This is part of why I haven't put much effort into the document - > re-telling a story can be a lot of work. > Thanks for reviewing my patchset. Yeah, sometimes it's difficult to fit in the context and match the writing style. Most part of the article is still valid, adding annotations may be better than rewrite. Let me revise it and send in the v2, though It may take a while. thanks, fox > NeilBrown