From: Akinobu Mita <akinobu.mita@gmail.com>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: Rob Herring <robherring2@gmail.com>,
Jej B <James.Bottomley@hansenpartnership.com>,
Paul Bolle <pebolle@tiscali.nl>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, Santosh Y <santoshsy@gmail.com>,
linux-scsi-owner@vger.kernel.org,
Subhash Jadavani <subhashj@codeaurora.org>,
Gilad Broner <gbroner@codeaurora.org>,
Dolev Raviv <draviv@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v3 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes
Date: Wed, 21 Oct 2015 23:51:10 +0900 [thread overview]
Message-ID: <CAC5umyjOcU-Do39XjoghwpF5WGBzxrFgS2nVjrD93ALLcnVPNQ@mail.gmail.com> (raw)
In-Reply-To: <1441188795-4600-8-git-send-email-ygardi@codeaurora.org>
2015-09-02 19:13 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
> According to UFS device specification REQUEST_SENSE command can
> only report back up to 18 bytes of data.
>
> Signed-off-by: Gilad Broner <gbroner@codeaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---
> drivers/scsi/ufs/ufshcd.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 0e54183..217b5cf 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -42,6 +42,7 @@
>
> #include "ufshcd.h"
> #include "unipro.h"
> +#define UFSHCD_REQ_SENSE_SIZE 18
We usually put a blank line between #include and #define.
next prev parent reply other threads:[~2015-10-21 14:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 10:13 [PATCH v3 00/15] Big fixes, retries, handle a race condition Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 02/15] scsi: ufs: clear fields " Yaniv Gardi
2015-10-22 7:14 ` subhashj
2015-09-02 10:13 ` [PATCH v3 03/15] scsi: ufs: verify command tag validity Yaniv Gardi
2015-10-21 14:48 ` Akinobu Mita
2015-10-25 13:29 ` ygardi
2015-10-22 7:17 ` subhashj
2015-09-02 10:13 ` [PATCH v3 04/15] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi
2015-10-22 7:17 ` subhashj
2015-09-02 10:13 ` [PATCH v3 05/15] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi
2015-10-23 11:18 ` Akinobu Mita
2015-10-25 13:38 ` ygardi
2015-10-26 12:59 ` Akinobu Mita
2015-09-02 10:13 ` [PATCH v3 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes Yaniv Gardi
2015-10-21 14:51 ` Akinobu Mita [this message]
2015-09-02 10:13 ` [PATCH v3 08/15] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 09/15] scsi: ufs: add retries for hibern8 enter Yaniv Gardi
2015-10-21 14:54 ` Akinobu Mita
2015-10-25 13:45 ` ygardi
2015-09-02 10:13 ` [PATCH v3 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 11/15] scsi: ufs: retry failed query flag requests Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 12/15] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi
2015-10-21 14:57 ` Akinobu Mita
2015-10-22 13:19 ` Akinobu Mita
2015-10-25 14:34 ` ygardi
2015-09-02 10:13 ` [PATCH v3 13/15] scsi: ufs: add missing memory barriers Yaniv Gardi
2015-10-22 13:21 ` Akinobu Mita
2015-10-25 14:40 ` ygardi
2015-10-26 12:23 ` Akinobu Mita
2015-10-26 12:35 ` ygardi
2015-10-27 10:21 ` ygardi
2015-09-02 10:13 ` [PATCH v3 14/15] scsi: ufs: commit descriptors before setting the doorbell Yaniv Gardi
2015-09-02 10:13 ` [PATCH v3 15/15] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC5umyjOcU-Do39XjoghwpF5WGBzxrFgS2nVjrD93ALLcnVPNQ@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=robherring2@gmail.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).