From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756344AbcHCQA2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Aug 2016 12:00:28 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:32819 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753044AbcHCQAZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Aug 2016 12:00:25 -0400
MIME-Version: 1.0
In-Reply-To: <1470225791-16613-4-git-send-email-wagi@monom.org>
References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-4-git-send-email-wagi@monom.org>
From: Kamal Dasu <kdasu.kdev@gmail.com>
Date: Wed, 3 Aug 2016 12:00:23 -0400
Message-ID: <CAC=U0a07p0Dx1UAme0=4b5DWpbVZvqk2nSN_TCXCGtVQM=U=Yw@mail.gmail.com>
Subject: Re: [PATCH v0 3/4] i2c: brcmstb: Use complete() instead of complete_all()
To: Daniel Wagner <wagi@monom.org>
Cc: Wolfram Sang <wsa@the-dreams.de>, Beniamino Galvani <b.galvani@gmail.com>,
        Ray Jui <rjui@broadcom.com>, Tim Kryger <tim.kryger@linaro.org>,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        "Jayachandran C <jchandra@broadcom.com>, bcm-kernel-feedback-list" 
	<bcm-kernel-feedback-list@broadcom.com>,
        linux-kernel@vger.kernel.org,
        Daniel Wagner <daniel.wagner@bmw-carit.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

LGTM

On Wed, Aug 3, 2016 at 8:03 AM, Daniel Wagner <wagi@monom.org> wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> brcmstb_send_i2c_cmd()
>   reinit_completion()
>   ...
>   /* initiate transfer by setting iic_enable */
>   ...
>   brcmstb_i2c_wait_for_completion()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>

Reviewed-by: Kamal Dasu <kdasu.kdev@gmail.com>

> ---
>  drivers/i2c/busses/i2c-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
> index 6a8cfc1..ab4ff96 100644
> --- a/drivers/i2c/busses/i2c-brcmstb.c
> +++ b/drivers/i2c/busses/i2c-brcmstb.c
> @@ -228,7 +228,7 @@ static irqreturn_t brcmstb_i2c_isr(int irq, void *devid)
>                 return IRQ_NONE;
>
>         brcmstb_i2c_enable_disable_irq(dev, INT_DISABLE);
> -       complete_all(&dev->done);
> +       complete(&dev->done);
>
>         dev_dbg(dev->device, "isr handled");
>         return IRQ_HANDLED;
> --
> 2.7.4