* [PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek
@ 2020-06-14 1:48 Aditya Pakki
2020-06-16 6:11 ` Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2020-06-14 1:48 UTC (permalink / raw)
To: pakki001
Cc: kjlu, wu000273, Ben Skeggs, David Airlie, Daniel Vetter,
dri-devel, nouveau, linux-kernel
nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that
increments the reference count. In case of failure, decrement the
ref count before returning the error.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index 63b5c8cf9ae4..8f63cda3db17 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -54,8 +54,10 @@ nouveau_debugfs_strap_peek(struct seq_file *m, void *data)
int ret;
ret = pm_runtime_get_sync(drm->dev->dev);
- if (ret < 0 && ret != -EACCES)
+ if (ret < 0 && ret != -EACCES) {
+ pm_runtime_put_autosuspend(drm->dev->dev);
return ret;
+ }
seq_printf(m, "0x%08x\n",
nvif_rd32(&drm->client.device.object, 0x101000));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek
2020-06-14 1:48 [PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek Aditya Pakki
@ 2020-06-16 6:11 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2020-06-16 6:11 UTC (permalink / raw)
To: Aditya Pakki
Cc: wu000273, David Airlie, ML nouveau, kjlu, LKML, ML dri-devel, Ben Skeggs
Thanks,
I've grabbed this, and the others of the same sort you sent out at the
same time.
Ben.
On Mon, 15 Jun 2020 at 17:29, Aditya Pakki <pakki001@umn.edu> wrote:
>
> nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that
> increments the reference count. In case of failure, decrement the
> ref count before returning the error.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> index 63b5c8cf9ae4..8f63cda3db17 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> @@ -54,8 +54,10 @@ nouveau_debugfs_strap_peek(struct seq_file *m, void *data)
> int ret;
>
> ret = pm_runtime_get_sync(drm->dev->dev);
> - if (ret < 0 && ret != -EACCES)
> + if (ret < 0 && ret != -EACCES) {
> + pm_runtime_put_autosuspend(drm->dev->dev);
> return ret;
> + }
>
> seq_printf(m, "0x%08x\n",
> nvif_rd32(&drm->client.device.object, 0x101000));
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 1:48 [PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek Aditya Pakki
2020-06-16 6:11 ` Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).