From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDECC47425 for ; Fri, 2 Oct 2020 10:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E415A206DD for ; Fri, 2 Oct 2020 10:08:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="o7V4Ert5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387755AbgJBKIR (ORCPT ); Fri, 2 Oct 2020 06:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387726AbgJBKIQ (ORCPT ); Fri, 2 Oct 2020 06:08:16 -0400 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75721C0613E4 for ; Fri, 2 Oct 2020 03:08:16 -0700 (PDT) Received: by mail-oo1-xc43.google.com with SMTP id h8so200685ooc.12 for ; Fri, 02 Oct 2020 03:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OWYUsZ+0jSI+bzR+U/Opb/r+h29XMQ6OibUPAn5KgDU=; b=o7V4Ert5THuV208ZrTVLXy9I6K5MtKtKfL97eluip4dXo5wrNSzqZOFdA61OxeBZdF +0sDtnWTrKMU2EyF3sU05PklgBIgEr9VudLtUJ3VGUdiPp1p6SCDlWNKteN+kFZ+fPDX WtxmCVPPFeGStQHm7e7rsN0pF8YjBqtA/PWcI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OWYUsZ+0jSI+bzR+U/Opb/r+h29XMQ6OibUPAn5KgDU=; b=P7E+mh0Y/0Den8xJ6Yw75a/sYodbxXoCH8btT1j4rL30FIkcLjXo1H4NAAMtMNlt9Y 3dKZD7LYSHhccFaNbajWYSWJjA9EfKB7AjWRALRpPkOCljREGKA+jvGJ6tZvP64XkP79 bcjZ+JKqM/B9ATacgayHTrPCyHBoAOlp9cN+1ip0MnuGrsE4H/rmk4dt5aykzmlT13yj 52WUJXCxUYKfq5bXBWePsIXxK+mX9yCFuqfuTFX9GhmiAqY8BksVtf43Xipe5ybnrUDC kcwn4zLJQ4SMzENU7GDArmUPC9lNu1gLrG5WlRIAio7lsRYYwnKgIR9IS9RoejT5MyQy c8Cg== X-Gm-Message-State: AOAM531V0vDmvh+C6OQUgTDimmIj/xjbBASrKW0n+BmTiTL9XTjKBuhg UDyn/CmVRLxO2xgSAjJkEAQBQDYG30z5cvlqr6RQqw== X-Google-Smtp-Source: ABdhPJzgSjaquUtXDnzTcQzO4uhxmbkV4B9/CSU56HbCERpxhB4ybkcXsdueLdZM5yjhwxK6nlWgW4Z+45On+tgp5ME= X-Received: by 2002:a4a:81:: with SMTP id 123mr1287156ooh.80.1601633295629; Fri, 02 Oct 2020 03:08:15 -0700 (PDT) MIME-Version: 1.0 References: <20200928090805.23343-1-lmb@cloudflare.com> <20200928090805.23343-3-lmb@cloudflare.com> <20200929055851.n7fa3os7iu7grni3@kafai-mbp> <20201001072348.hxhpuoqmeln6twxw@ast-mbp.dhcp.thefacebook.com> In-Reply-To: From: Lorenz Bauer Date: Fri, 2 Oct 2020 11:08:04 +0100 Message-ID: Subject: Re: [PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare socket cookies To: Alexei Starovoitov Cc: Andrii Nakryiko , Martin KaFai Lau , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , kernel-team , "open list:KERNEL SELFTEST FRAMEWORK" , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Oct 2020 at 18:11, Alexei Starovoitov wrote: > > > > I think this might be the same problem I fixed for libbpf with [0]. > > Turns out, GCC explicitly calls out (somewhere in their docs) that > > uninitialized variable warnings work only when compiled in optimized > > mode, because some internal data structures used to detect this are > > only maintained in optimized mode build. > > > > Laurenz, can you try compiling your example with -O2? > > All of my experiments I did with -O2. If anybody wants to play with this more: https://godbolt.org/z/77P6P9 Seems like red hat GCC has some special sauce that fixes this behaviour? -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com