From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFB4C4332F for ; Tue, 1 Nov 2022 17:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiKARD0 (ORCPT ); Tue, 1 Nov 2022 13:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiKARDY (ORCPT ); Tue, 1 Nov 2022 13:03:24 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67329A4 for ; Tue, 1 Nov 2022 10:03:21 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id f5so17088620ejc.5 for ; Tue, 01 Nov 2022 10:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BmOzTOknKLYK8DbDZpYjaVcrV5Rf9u7VBwmv6gC9EQg=; b=IC2ritDxFfviQyivZT1zEPdBHtRvQheBhy87DVoM2Dnn4hrKtKUj+Q5jVpTwAJ6AUt 1PflSYX85K1ScAwgTcalIluR3ShrwF3HvH2hATRukFHMvxYKv+Z3EIk4Tg7/EO8B7UlQ b2lO9fdC3SEL/NZ1IMFoJwDEHI7G0LHIhj4yP2QJgMrnSicur8XEz/3SWho/Ca2qcdCp AhYGV1YmG0mA8G0JdxFbMoghbhOE4m1JI3Xudk/cfuyYzTVEUZd2SlgPpzxE3M3dLuE4 w4YiNTTY4I7Sa44+0yFlAT/VShoywczeaJw5PTSKIh/tha0bJ31algwl+oMDM8QCYPm+ VfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BmOzTOknKLYK8DbDZpYjaVcrV5Rf9u7VBwmv6gC9EQg=; b=cjPJ6vl20Ikg0scbAxkEzxfuUeGpPY8gviZmKXURF0D0JxMG2iZcmKddUcqVVyi6ha 3/L2fHgyfv9pgpiqZyvCdLXCvSyvy7PDvPVANTIKn0nz+9w86przohoJVlLEA/9UxlmH yhMeJ8la9AvDpzjpt57JW4LfNbBCoal6TaaMKxpRxT5vEpggD4hDP74T23iMQJLNuB6x 7D/X06dSudlpZfNLknXLeR7t0Es8gRSqHHjsuOI3hLcbF9HAd1o67lgoAhZybWLaP8Sa E0SeS36H0a3DFscCfNIoaPIHjUiE4tluyJcsEMMK0VXJmCZEuwWO1lyGsszjVgRReX5p 7xYA== X-Gm-Message-State: ACrzQf3XgqUt8SeqD8L/KWgMf1v0CRJQ31FuIsJClOn/VYXzSvOLfG2f /z2CfKdidY2LYgSJfhYVc3XexcTKnlP8aoigD79CmLaBU0M= X-Google-Smtp-Source: AMsMyM5iD9QIGkzpSWJvRSHJcLR0py6LxhfUPirqCdA/nZTRd5GGthw+pZdfhJvjr/BvZMJQaiXrkWuJVBekRM6v1jg= X-Received: by 2002:a17:906:fc1e:b0:780:93d2:8510 with SMTP id ov30-20020a170906fc1e00b0078093d28510mr149190ejb.457.1667322199705; Tue, 01 Nov 2022 10:03:19 -0700 (PDT) MIME-Version: 1.0 References: <20221024113005.376059449@linuxfoundation.org> <20221029011211.4049810-1-ovt@google.com> In-Reply-To: From: Oleksandr Tymoshenko Date: Tue, 1 Nov 2022 10:03:07 -0700 Message-ID: Subject: Re: [PATCH 5.4 086/255] once: add DO_ONCE_SLOW() for sleepable contexts To: Greg KH Cc: Nathan Chancellor , christophe.leroy@csgroup.eu, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, sashal@kernel.org, stable@vger.kernel.org, w@1wt.eu, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 31, 2022 at 11:25 PM Greg KH wrote: > > On Tue, Nov 01, 2022 at 05:48:29AM +0100, Greg KH wrote: > > On Mon, Oct 31, 2022 at 11:27:21AM -0700, Nathan Chancellor wrote: > > > Hi Oleksandr, > > > > > > On Sat, Oct 29, 2022 at 01:12:11AM +0000, Oleksandr Tymoshenko wrote: > > > > Hello, > > > > > > > > This commit causes the following panic in kernel built with clang > > > > (GCC build is not affected): > > > > > > > > [ 8.320308] BUG: unable to handle page fault for address: ffffffff97216c6a [26/4066] > > > > [ 8.330029] #PF: supervisor write access in kernel mode > > > > [ 8.337263] #PF: error_code(0x0003) - permissions violation > > > > [ 8.344816] PGD 12e816067 P4D 12e816067 PUD 12e817063 PMD 800000012e2001e1 > > > > [ 8.354337] Oops: 0003 [#1] SMP PTI > > > > [ 8.359178] CPU: 2 PID: 437 Comm: curl Not tainted 5.4.220 #15 > > > > [ 8.367241] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > > > > [ 8.378529] RIP: 0010:__do_once_slow_done+0xf/0xa0 > > > > [ 8.384962] Code: 1b 84 db 74 0c 48 c7 c7 80 ce 8d 97 e8 fa e9 4a 00 84 db 0f 94 c0 5b 5d c3 66 90 55 48 89 e5 41 57 41 56 > > > > 53 49 89 d7 49 89 f6 07 01 48 c7 c7 80 ce 8d 97 e8 d2 e9 4a 00 48 8b 3d 9b de c9 00 > > > > [ 8.409066] RSP: 0018:ffffb764c02d3c90 EFLAGS: 00010246 > > > > [ 8.415697] RAX: 4f51d3d06bc94000 RBX: d474b86ddf7162eb RCX: 000000007229b1d6 > > > > [ 8.424805] RDX: 0000000000000000 RSI: ffffffff9791b4a0 RDI: ffffffff97216c6a > > > > [ 8.434108] RBP: ffffb764c02d3ca8 R08: 0e81c130f1159fc1 R09: 1d19d60ce0b52c77 > > > > [ 8.443408] R10: 8ea59218e6892b1f R11: d5260237a3c1e35c R12: ffff9c3dadd42600 > > > > [ 8.452468] R13: ffffffff97910f80 R14: ffffffff9791b4a0 R15: 0000000000000000 > > > > [ 8.461416] FS: 00007eff855b40c0(0000) GS:ffff9c3db7a80000(0000) knlGS:0000000000000000 > > > > [ 8.471632] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > [ 8.478763] CR2: ffffffff97216c6a CR3: 000000022ded0000 CR4: 00000000000006a0 > > > > [ 8.487789] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > > [ 8.496684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > > [ 8.505443] Call Trace: > > > > [ 8.508568] __inet_hash_connect+0x523/0x530 > > > > [ 8.513839] ? inet_hash_connect+0x50/0x50 > > > > [ 8.518818] ? secure_ipv4_port_ephemeral+0x69/0xe0 > > > > [ 8.525003] tcp_v4_connect+0x2c5/0x410 > > > > [ 8.529858] __inet_stream_connect+0xd7/0x360 > > > > [ 8.535329] ? _raw_spin_unlock+0xe/0x10 > > > > ... skipped ... > > > > > > > > > > > > The root cause is the difference in __section macro semantics between 5.4 and > > > > later LTS releases. On 5.4 it stringifies the argument so the ___done > > > > symbol is created in a bogus section ".data.once", with double quotes: > > > > > > > > % readelf -S vmlinux | grep data.once > > > > [ 5] ".data.once" PROGBITS ffffffff82216c6a 01416c6a > > > > > > Thanks for the report! The reason this does not happen in mainline is > > > due to commit 33def8498fdd ("treewide: Convert macro and uses of > > > __section(foo) to __section("foo")"), which came as a result of these > > > issues: > > > > > > https://github.com/ClangBuiltLinux/linux/issues/619 > > > https://llvm.org/pr42950 > > > > > > To keep stable from diverging, it would probably be best to pick > > > 33def8498fdd and fight through whatever conflicts there are. If that is > > > not a suitable solution, the next best thing would be to remove the > > > quotes like was done in commit bfafddd8de42 ("include/linux/compiler.h: > > > fix Oops for Clang-compiled kernels") for all instances of > > > __section(...) or __attribute__((__section__(...))), which should > > > resolve the specific problem you are seeing. > > > > I think we should do the latter, fighting with all of the different > > section entries would be a pain. > > > > Unless someone beats me to it, I'll go make up a patch for this... > > Can someone test the following patch: The patch fixes the issue for me, the system boots fine. > > > diff --git a/include/linux/once.h b/include/linux/once.h > index bb58e1c3aa03..3a6671d961b9 100644 > --- a/include/linux/once.h > +++ b/include/linux/once.h > @@ -64,7 +64,7 @@ void __do_once_slow_done(bool *done, struct static_key_true *once_key, > #define DO_ONCE_SLOW(func, ...) \ > ({ \ > bool ___ret = false; \ > - static bool __section(".data.once") ___done = false; \ > + static bool __section(.data.once) ___done = false; \ > static DEFINE_STATIC_KEY_TRUE(___once_key); \ > if (static_branch_unlikely(&___once_key)) { \ > ___ret = __do_once_slow_start(&___done); \