From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: syzbot <syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux@dominikbrodowski.net, mpm@selenic.com,
syzkaller-bugs@googlegroups.com,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
yuehaibing@huawei.com
Subject: Re: [syzbot] INFO: task hung in add_early_randomness (2)
Date: Wed, 8 Jun 2022 09:19:06 +0800 [thread overview]
Message-ID: <CACGkMEseR-vDzgei21jftC8Grm0Not+e1XEefyLgV8C4yfWOHQ@mail.gmail.com> (raw)
In-Reply-To: <20220607063908-mutt-send-email-mst@kernel.org>
On Tue, Jun 7, 2022 at 6:54 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Jun 07, 2022 at 05:05:41PM +0800, Jason Wang wrote:
> > On Tue, Jun 7, 2022 at 3:30 PM syzbot
> > <syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com> wrote:
> > >
> > > syzbot has bisected this issue to:
> > >
> > > commit 8b4ec69d7e098a7ddf832e1e7840de53ed474c77
> > > Author: Jason Wang <jasowang@redhat.com>
> > > Date: Fri May 27 06:01:19 2022 +0000
> > >
> > > virtio: harden vring IRQ
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1175c3c7f00000
> > > start commit: f2906aa86338 Linux 5.19-rc1
> > > git tree: upstream
> > > final oops: https://syzkaller.appspot.com/x/report.txt?x=1375c3c7f00000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=1575c3c7f00000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=cbd131cc02ee620e
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=5b59d6d459306a556f54
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=104f4d4ff00000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14d6782df00000
> > >
> > > Reported-by: syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com
> > > Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ")
> > >
> > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> > >
> >
> > I wonder if it's related to shared IRQ.
> >
> > Want to know if the attached patch works.
> >
> > Thanks
>
> Please, post patches inline.
> In this case I don't see the printk in the console.
>
Ok, let's try this:
#syz test
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 13a7348cedff..1af55e576505 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -2137,7 +2137,7 @@ irqreturn_t vring_interrupt(int irq, void *_vq)
if (unlikely(vq->broken)) {
dev_warn_once(&vq->vq.vdev->dev,
"virtio vring IRQ raised before DRIVER_OK");
- return IRQ_NONE;
+ return IRQ_HANDLED;
}
/* Just a hint for performance: so it's ok that this can be racy! */
next prev parent reply other threads:[~2022-06-08 4:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 6:49 [syzbot] INFO: task hung in add_early_randomness (2) syzbot
2022-06-07 1:50 ` syzbot
2022-06-07 7:30 ` syzbot
2022-06-07 9:05 ` Jason Wang
2022-06-07 10:35 ` Michael S. Tsirkin
2022-06-07 10:53 ` Michael S. Tsirkin
2022-06-08 1:19 ` Jason Wang [this message]
2022-06-08 1:37 ` syzbot
2022-06-08 2:35 ` Jason Wang
2022-06-08 2:37 ` syzbot
2022-06-08 2:50 ` Jason Wang
2022-06-08 2:51 ` syzbot
2022-06-08 2:56 ` Jason Wang
2022-06-08 3:15 ` syzbot
2022-06-08 6:07 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACGkMEseR-vDzgei21jftC8Grm0Not+e1XEefyLgV8C4yfWOHQ@mail.gmail.com \
--to=jasowang@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mpm@selenic.com \
--cc=mst@redhat.com \
--cc=syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).