From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF18BCCA485 for ; Thu, 21 Jul 2022 09:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232030AbiGUJRb (ORCPT ); Thu, 21 Jul 2022 05:17:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiGUJRa (ORCPT ); Thu, 21 Jul 2022 05:17:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 54BFE402CD for ; Thu, 21 Jul 2022 02:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658395048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bR+13URxlsE5fUg4TpB1VjQB2DqN5gnlwoyPW0ASkV4=; b=iw/Imv9PmgfqY2qXC2EKYrZ2QZrmrOPnLZWVlIJrClIIoC2eootbWaV1/k8+Wj8norcKjL 07zBOwqSdxJwnD6+WZptfJPrVLmUTjS5pOs2/0w+rj6SNra6MuDBeT0PCwnGupwZOJaBwf nSMqF58TPQiF2JtQ7hD6eCkfi3LL1s8= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-294-aoZMOSfyOGOJWkloMTvQrA-1; Thu, 21 Jul 2022 05:17:27 -0400 X-MC-Unique: aoZMOSfyOGOJWkloMTvQrA-1 Received: by mail-lj1-f197.google.com with SMTP id t14-20020a2e780e000000b0025d63d1c965so158729ljc.13 for ; Thu, 21 Jul 2022 02:17:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bR+13URxlsE5fUg4TpB1VjQB2DqN5gnlwoyPW0ASkV4=; b=PfXCT8H49tMYiFnfAtolhE3Q788fLzKjxDViSqUPSlTAG5DuTzdlfnM1HEpgz2Peqe miSTAh3Eyuy1gJYhYFRR31N7dOaqiGeM3FRL6251xcJA83OsYzFQzzTu8mbRxZIcJNiu IFF8020yrF8LxvPAsI55YbJcBi7jyES4h/khNGdkao8QXfWdOoQYAPk3cIupZrl6mT55 N4pQA64fB/h2lq5J7RD5yjPQU7t/VdBA28wBOZ5etVlqVS9OoXLh5bFMKEJoHeijuVzo ZsFMY1J78V6g0vvTp2ZVwRNFbH5uIxqEPykxiXqs+Jgz23mPpG0jN4Ly07jJlazRUiOW i7yg== X-Gm-Message-State: AJIora/EVeIvyvaScNf69skEfk/rSblInG6SfDSxXvvFiOb83E0DLoNa bpWdEhLEmk+iNh39EFBzAmbp6Dje1i41lNElc9xhderQ7cSO9sDQ5e0Zie3LGVN95pT6q8mfwgb P45SAQdPJ9KLvrCFaGY+o9TGwx/MSJtQy3o9lHCt3 X-Received: by 2002:ac2:4c4c:0:b0:489:fe2c:c877 with SMTP id o12-20020ac24c4c000000b00489fe2cc877mr23999866lfk.238.1658395045578; Thu, 21 Jul 2022 02:17:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u24Xku7CH2NvwPr1v5mlb7apJiFJtOLNJ3rS6Tv1FeUAK8VufO6AwqK+LPzXVGJzRjJ+q60K4VfTtan1dp7c4= X-Received: by 2002:ac2:4c4c:0:b0:489:fe2c:c877 with SMTP id o12-20020ac24c4c000000b00489fe2cc877mr23999841lfk.238.1658395045042; Thu, 21 Jul 2022 02:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20220721084341.24183-1-qtxuning1999@sjtu.edu.cn> In-Reply-To: <20220721084341.24183-1-qtxuning1999@sjtu.edu.cn> From: Jason Wang Date: Thu, 21 Jul 2022 17:17:13 +0800 Message-ID: Subject: Re: [RFC 0/5] In virtio-spec 1.1, new feature bit VIRTIO_F_IN_ORDER was introduced. To: Guo Zhi Cc: eperezma , Stefano Garzarella , mst , netdev , linux-kernel , kvm , virtualization Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 4:44 PM Guo Zhi wrote: > > When this feature has been negotiated, virtio driver will use > descriptors in ring order: starting from offset 0 in the table, and > wrapping around at the end of the table. Vhost devices will always use > descriptors in the same order in which they have been made available. > This can reduce virtio accesses to used ring. > > Based on updated virtio-spec, this series realized IN_ORDER prototype > in virtio driver and vhost. Thanks a lot for the series. I wonder if you can share any performance numbers for this? Thanks > > Guo Zhi (5): > vhost: reorder used descriptors in a batch > vhost: announce VIRTIO_F_IN_ORDER support > vhost_test: batch used buffer > virtio: get desc id in order > virtio: annouce VIRTIO_F_IN_ORDER support > > drivers/vhost/test.c | 15 +++++++++++- > drivers/vhost/vhost.c | 44 ++++++++++++++++++++++++++++++++++-- > drivers/vhost/vhost.h | 4 ++++ > drivers/virtio/virtio_ring.c | 39 +++++++++++++++++++++++++------- > 4 files changed, 91 insertions(+), 11 deletions(-) > > -- > 2.17.1 >