From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: virtualization <virtualization@lists.linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Eugenio Pérez" <eperezma@redhat.com>
Subject: Re: [PATCH 3/3] vdpa_sim_blk: call vringh_complete_iotlb() also in the error path
Date: Thu, 23 Jun 2022 11:52:19 +0800 [thread overview]
Message-ID: <CACGkMEv1Y_rKSc799qi2=EkrQfm4E_d9aMWefXyz5h4vdXjxgA@mail.gmail.com> (raw)
In-Reply-To: <20220621161252.197173-1-sgarzare@redhat.com>
On Wed, Jun 22, 2022 at 12:13 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> Call vringh_complete_iotlb() even when we encounter a serious error
> that prevents us from writing the status in the "in" header
> (e.g. the header length is incorrect, etc.).
>
> The guest is misbehaving, so maybe the ring is in a bad state, but
> let's avoid making things worse.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> index ac86478845b6..de9cd9843143 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> @@ -63,6 +63,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> {
> size_t pushed = 0, to_pull, to_push;
> struct virtio_blk_outhdr hdr;
> + bool handled = false;
> ssize_t bytes;
> loff_t offset;
> u64 sector;
> @@ -78,12 +79,12 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> if (vq->out_iov.used < 1 || vq->in_iov.used < 1) {
> dev_dbg(&vdpasim->vdpa.dev, "missing headers - out_iov: %u in_iov %u\n",
> vq->out_iov.used, vq->in_iov.used);
> - return false;
> + goto err;
> }
>
> if (vq->in_iov.iov[vq->in_iov.used - 1].iov_len < 1) {
> dev_dbg(&vdpasim->vdpa.dev, "request in header too short\n");
> - return false;
> + goto err;
> }
>
> /* The last byte is the status and we checked if the last iov has
> @@ -97,7 +98,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> sizeof(hdr));
> if (bytes != sizeof(hdr)) {
> dev_dbg(&vdpasim->vdpa.dev, "request out header too short\n");
> - return false;
> + goto err;
> }
>
> to_pull -= bytes;
> @@ -182,16 +183,19 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> /* Last byte is the status */
> bytes = vringh_iov_push_iotlb(&vq->vring, &vq->in_iov, &status, 1);
> if (bytes != 1)
> - return false;
> + goto err;
>
> pushed += bytes;
>
> /* Make sure data is wrote before advancing index */
> smp_wmb();
>
> + handled = true;
> +
> +err:
> vringh_complete_iotlb(&vq->vring, vq->head, pushed);
>
> - return true;
> + return handled;
> }
>
> static void vdpasim_blk_work(struct work_struct *work)
> --
> 2.36.1
>
prev parent reply other threads:[~2022-06-23 4:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:08 [PATCH 0/3] vdpa_sim_blk: several fixes for the vDPA block simulator Stefano Garzarella
2022-06-21 16:08 ` [PATCH 1/3] vdpa_sim_blk: use dev_dbg() to print errors Stefano Garzarella
2022-06-23 3:40 ` Jason Wang
2022-06-21 16:08 ` [PATCH 2/3] vdpa_sim_blk: limit the number of request handled per batch Stefano Garzarella
2022-06-23 3:50 ` Jason Wang
2022-06-23 8:58 ` Stefano Garzarella
2022-06-28 4:01 ` Jason Wang
2022-06-28 7:55 ` Stefano Garzarella
2022-06-21 16:12 ` [PATCH 3/3] vdpa_sim_blk: call vringh_complete_iotlb() also in the error path Stefano Garzarella
2022-06-23 3:52 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEv1Y_rKSc799qi2=EkrQfm4E_d9aMWefXyz5h4vdXjxgA@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).