From: Rajat Jain <rajatja@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>,
Harry Cutts <hcutts@chromium.org>,
Mathew King <mathewk@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode
Date: Thu, 26 Mar 2020 11:30:12 -0700 [thread overview]
Message-ID: <CACK8Z6FgXJZsNNHJ_2K9TTKzAv6Hu=jmSLbf3e41ohbcZe5Chw@mail.gmail.com> (raw)
In-Reply-To: <20200326182711.GA259753@dtor-ws>
On Thu, Mar 26, 2020 at 11:27 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> We should try to keep keycodes sequential unless there is a reason to leave
> a gap in numbering, so let's move it from 0x280 to 0x27a while we still
> can.
>
> Fixes: 3b059da9835c ("Input: allocate keycode for Selective Screenshot key")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Rajat Jain <rajatja@google.com>
Thanks! My apologies for overlooking.
> ---
> include/uapi/linux/input-event-codes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 008be2609ce1..6923dc7e0298 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -653,7 +653,7 @@
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> /* Select an area of screen to be copied */
> -#define KEY_SELECTIVE_SCREENSHOT 0x280
> +#define KEY_SELECTIVE_SCREENSHOT 0x27a
>
> /*
> * Some keyboards have keys which do not have a defined meaning, these keys
> --
> 2.26.0.rc2.310.g2932bb562d-goog
>
>
> --
> Dmitry
prev parent reply other threads:[~2020-03-26 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 18:27 [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode Dmitry Torokhov
2020-03-26 18:30 ` Rajat Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACK8Z6FgXJZsNNHJ_2K9TTKzAv6Hu=jmSLbf3e41ohbcZe5Chw@mail.gmail.com' \
--to=rajatja@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hcutts@chromium.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathewk@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).