From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1735C1B0F1 for ; Tue, 19 Jun 2018 22:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88ED320693 for ; Tue, 19 Jun 2018 22:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="o/mfD6jx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88ED320693 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965088AbeFSWSa (ORCPT ); Tue, 19 Jun 2018 18:18:30 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:33309 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964949AbeFSWS0 (ORCPT ); Tue, 19 Jun 2018 18:18:26 -0400 Received: by mail-yb0-f195.google.com with SMTP id e84-v6so516267ybb.0 for ; Tue, 19 Jun 2018 15:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wSe+OmkgmTCnaER2cb7DzpJkBEG5Omh2Zt7bm2q68kQ=; b=o/mfD6jxpzAVsKiX3n6SHThgp2y41E8c5eWFCWA4IQU76RhXlzz70p+R+DVzTHhUIZ jmEgmE5fdIp8YwaxWS1Ky4/wAasx6a0iISTS0+JIWZRvK/1JpzuphfiaNkyHkFxUo75h ceGJ3UXyjb+K7TdmL2x8+6fl23tAneDaY/YePfxEs/pIkBTYQkKM+OnBU/Grg43fGl/N 1trnuDmVM3N7y9u1wdnp3C+RhpLhM+/94bjNOHAEQ5uXxfzXxNcK2Uxn1m1zYtDl1wA2 2SKP0r29Jv5ATH3CBYMCQV2wLlJJy2pPxscLER4iPnow7NFuNXkeuAXipeq2KJW5MhnO V05Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wSe+OmkgmTCnaER2cb7DzpJkBEG5Omh2Zt7bm2q68kQ=; b=kayNQBePS565BMSZvrJLuvOqkKlcSj2KLH5aEmf8o/scvWk1aXy92JMSMxRujO7Nvn BEr4NGLk0FtK+tiOBBKy7x/gUFeTp1IJZS7VxSkcYGl4pVUZ63gWzJlcJVxyseD31M2k Ie//820MYdPFrKVKFAeAMSM29mBjd6da2UrnpoMAxM+V65EuxPUyRIw3Oyr3rjGGen4e e+qEzyW0PDgU+2INNU9NaJiDewQDlSNKs9s8PfCkn+Ld1tRML9810LlzRbMzbpilihkh MthAaiJrlldcbSncPgAksMEOi48b1KG3cj7KPJhQraq+0DeDPve7CY96wRXxCEJRk8eb PFPQ== X-Gm-Message-State: APt69E0bukHOOILobCeytsR3/NTg59W5KzGQz54ONgsILGvneDufHRQp vNzeJnUNPgXCeRLpBRaZbWrsy8J3yIWRGh6h5teikA== X-Google-Smtp-Source: ADUXVKIDeBbjiNsdwgQjDxKvaf0/vQ3kVcTMZwDZaICdJdgOOQ4bEXInigFRtR964VstMeQ1lsypsHQGYE2r6WlGFtI= X-Received: by 2002:a25:9d0b:: with SMTP id i11-v6mr9444174ybp.1.1529446705212; Tue, 19 Jun 2018 15:18:25 -0700 (PDT) MIME-Version: 1.0 References: <20180522222805.80314-1-rajatja@google.com> <20180523175808.28030-1-rajatja@google.com> <20180619221651.GH33049@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20180619221651.GH33049@bhelgaas-glaptop.roam.corp.google.com> From: Rajat Jain Date: Tue, 19 Jun 2018 15:17:49 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] Expose PCIe AER stats via sysfs To: Bjorn Helgaas Cc: Bjorn Helgaas , Jonathan Corbet , Philippe Ombredanne , Kate Stewart , Thomas Gleixner , Greg Kroah-Hartman , Frederick Lawler , Oza Pawandeep , "Busch, Keith" , Gabriele Paoloni , Alexandru Gagniuc , Thomas Tai , Steven Rostedt , linux-pci , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Jes Sorensen , Kyle McMartin , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sure, no problem. Will do. On Tue, Jun 19, 2018 at 3:16 PM Bjorn Helgaas wrote: > > On Wed, May 23, 2018 at 10:58:03AM -0700, Rajat Jain wrote: > > This patchset exposes the AER stats via the sysfs attributes. > > > > Patchset v2 has minor changes to v1 based on the review comments, > > no functional change. > > Primarily: > > * Fix license header > > * Use tabs instead of spaces > > * Remove use on unlikely() etc > > * Move documentation to Documentation/ABI/ > > > > Rajat Jain (5): > > PCI/AER: Define and allocate aer_stats structure for AER capable > > devices > > PCI/AER: Add sysfs stats for AER capable devices > > PCI/AER: Add sysfs attributes to provide breakdown of AERs > > PCI/AER: Add sysfs attributes for rootport cumulative stats > > Documentation/ABI: Add details of PCI AER statistics > > > > .../testing/sysfs-bus-pci-devices-aer_stats | 103 ++++++++++ > > Documentation/PCI/pcieaer-howto.txt | 5 + > > drivers/pci/pci-sysfs.c | 3 + > > drivers/pci/pci.h | 4 +- > > drivers/pci/pcie/aer/Makefile | 2 +- > > drivers/pci/pcie/aer/aerdrv.h | 15 ++ > > drivers/pci/pcie/aer/aerdrv_core.c | 11 + > > drivers/pci/pcie/aer/aerdrv_errprint.c | 7 +- > > drivers/pci/pcie/aer/aerdrv_stats.c | 192 ++++++++++++++++++ > > drivers/pci/probe.c | 1 + > > include/linux/pci.h | 3 + > > 11 files changed, 342 insertions(+), 4 deletions(-) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats > > create mode 100644 drivers/pci/pcie/aer/aerdrv_stats.c > > I broke this by putting all the AER code in one file in v4.18-rc1, > sorry! Would you mind rebasing these on top of that? > > Since everything AER-related is now in aer.c, I'd suggest putting the > stats code there, too.