From: Michael Chan <michael.chan@broadcom.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: Netdev <netdev@vger.kernel.org>,
Siva Reddy Kallam <siva.kallam@broadcom.com>,
Prashant Sreedharan <prashant@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes
Date: Wed, 17 Jun 2020 12:07:08 -0700 [thread overview]
Message-ID: <CACKFLimXALz8LOPFiX7ar456CsucUf-wxmD4_KkJSmjXbZ-q+w@mail.gmail.com> (raw)
In-Reply-To: <20200617185117.732849-1-drc@linux.vnet.ibm.com>
On Wed, Jun 17, 2020 at 11:51 AM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> The driver function tg3_io_error_detected() calls napi_disable twice,
> without an intervening napi_enable, when the number of EEH errors exceeds
> eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.
>
> Add check for pcierr_recovery which skips code already executed for the
> "Frozen" state.
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Thanks.
next prev parent reply other threads:[~2020-06-17 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 19:01 [PATCH] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes David Christensen
2020-06-15 20:45 ` Michael Chan
2020-06-15 22:21 ` David Christensen
2020-06-16 1:33 ` Michael Chan
2020-06-17 18:51 ` [PATCH v2] " David Christensen
2020-06-17 19:07 ` Michael Chan [this message]
2020-06-19 3:35 ` David Miller
2020-07-25 0:19 ` David Christensen
2020-07-27 7:26 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLimXALz8LOPFiX7ar456CsucUf-wxmD4_KkJSmjXbZ-q+w@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=drc@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).