From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751765AbcLCSug (ORCPT <rfc822;w@1wt.eu>);
        Sat, 3 Dec 2016 13:50:36 -0500
Received: from mail-oi0-f43.google.com ([209.85.218.43]:35174 "EHLO
        mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751372AbcLCSuf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 3 Dec 2016 13:50:35 -0500
MIME-Version: 1.0
In-Reply-To: <1480758977-4234-1-git-send-email-bianpan2016@163.com>
References: <1480758977-4234-1-git-send-email-bianpan2016@163.com>
From: Michael Chan <michael.chan@broadcom.com>
Date: Sat, 3 Dec 2016 10:50:33 -0800
Message-ID: <CACKFLinpqUstx9+6BfNZK5iNQ4Sf8ktY+E6iAqBNdttz8qqGig@mail.gmail.com>
Subject: Re: [PATCH 1/1] netdev: broadcom: propagate error code
To: Pan Bian <bianpan2016@163.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        Prashant Sreedharan <prashant.sreedharan@broadcom.com>,
        Satish Baddipadige <sbaddipa@broadcom.com>,
        Netdev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 3, 2016 at 1:56 AM, Pan Bian <bianpan2016@163.com> wrote:
> Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call
> to _hwrm_send_message() fails. It may be better to propagate the errors
> to the caller of bnxt_hwrm_stat_ctx_alloc().
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Acked-by: Michael Chan <michael.chan@broadcom.com>