From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058EBC43460 for ; Mon, 19 Apr 2021 11:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E028A61166 for ; Mon, 19 Apr 2021 11:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238762AbhDSLpA (ORCPT ); Mon, 19 Apr 2021 07:45:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21526 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhDSLo6 (ORCPT ); Mon, 19 Apr 2021 07:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y644e2+cDS7jfFg2KG/GSDehn2zis7rBbTsBszQ7ZZc=; b=Xj5OgMP/8bzzrFhUyS6yRk73FcuDZWnm4R4azR7g7cRZsUoup72yF0uL+nBNgWSUcnvljC 9Jnwk7RTlwpKEximC68UZ4YTbqHo/NhiEviHdYFWCWGDT9HEwvmW30ouEqbrKGc/8+8FZL AAbW24dktgdDiB08UGgsLwr74NS3g4A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-0eYavrhIOrSp1Rqsc4heUQ-1; Mon, 19 Apr 2021 07:44:27 -0400 X-MC-Unique: 0eYavrhIOrSp1Rqsc4heUQ-1 Received: by mail-wm1-f72.google.com with SMTP id n11-20020a1c400b0000b02901339d16b8d7so1401683wma.7 for ; Mon, 19 Apr 2021 04:44:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=y644e2+cDS7jfFg2KG/GSDehn2zis7rBbTsBszQ7ZZc=; b=MqwxszCBLCrNMbnu0n1z1K84n8VcG9uWTOUlQiBPgqlhamI+9CnCBh+K+PWQ/jjEMZ oTAOWpfo5IiD9s+ta8kLhxeK/SMDThNVNxqfeC9PqxrUUCYYBYOMEpupqwZp3fEDPDK/ T21j9XJZs3NAYuKN8AvUivnz1x1Xpf5TpbwiHs0rpCCbadm8RuL+lnwQyo+GlOEUzfT/ D9zmYIz4SBHF7P2gkWKqsB7wp5TX+XXfC0TldClHncEWH4ysWPj/Sn+n7fflain8DXad 5yxyBda78OdP0GKGKIr0E8mxg+0yDgaE2G7a+3h53M+vvo/OL7S1+HAL4xsBqLR+gCqw mcLw== X-Gm-Message-State: AOAM531v4fAefECv7LI+B643uZnpouU57me8TAAIu79YMnzBd9rK6WL2 pqMIuoIWPjQvE4OGts6SlHrTwP/ISHy5bB1m3DY5EomWfOGrkIOmsakmjInRA35xa8X6UbCQAs+ Q5mRy0GekcVQJwJrrW6UKfjIcFJUsthklHWoJC7K6 X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13544850wrd.177.1618832666331; Mon, 19 Apr 2021 04:44:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjlugWDWLZH+5rQly0tRCQFzwosoMjd14Y9bJuAnMN5V/27+yHQMkQQGZjse8w/vAsAyaiT8Vc7UJvMHq5TOE= X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13544835wrd.177.1618832666229; Mon, 19 Apr 2021 04:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-8-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-8-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:44:15 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev' To: Lee Jones Cc: Jeremy Kolb , David Airlie , nouveau , LKML , dri-devel , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Ben Skeggs , Daniel Vetter , =?UTF-8?Q?Christian_K=C3=B6nig?= , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_bo.c: In function =E2=80=98nouveau_ttm_t= t_populate=E2=80=99: > drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable =E2=80= =98dev=E2=80=99 set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/nouveau/nouveau_bo.c: In function =E2=80=98nouveau_ttm_t= t_unpopulate=E2=80=99: > drivers/gpu/drm/nouveau/nouveau_bo.c:1252:17: warning: variable =E2=80= =98dev=E2=80=99 set but not used [-Wunused-but-set-variable] > > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian K=C3=B6nig" > Cc: Jeremy Kolb > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouve= au/nouveau_bo.c > index 3e09df0472ce4..37b3d2c10f5c5 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -1255,7 +1255,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev, > { > struct ttm_tt *ttm_dma =3D (void *)ttm; > struct nouveau_drm *drm; > - struct device *dev; > bool slave =3D !!(ttm->page_flags & TTM_PAGE_FLAG_SG); > > if (ttm_tt_is_populated(ttm)) > @@ -1268,7 +1267,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev, > } > > drm =3D nouveau_bdev(bdev); > - dev =3D drm->dev->dev; > > return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx); > } > @@ -1278,14 +1276,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_device *bdev= , > struct ttm_tt *ttm) > { > struct nouveau_drm *drm; > - struct device *dev; > bool slave =3D !!(ttm->page_flags & TTM_PAGE_FLAG_SG); > > if (slave) > return; > > drm =3D nouveau_bdev(bdev); > - dev =3D drm->dev->dev; > > return ttm_pool_free(&drm->ttm.bdev.pool, ttm); > } > -- > 2.27.0 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau