From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600A3C4338F for ; Tue, 3 Aug 2021 15:03:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44C1B61040 for ; Tue, 3 Aug 2021 15:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236681AbhHCPEE (ORCPT ); Tue, 3 Aug 2021 11:04:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26306 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236628AbhHCPD5 (ORCPT ); Tue, 3 Aug 2021 11:03:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628003025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7tbb0CsnnLf2HSZfxDfKO/Er3Zkctrt268hAInT4vLU=; b=bEFDZCksmFSIkYhYuRYLmvcOhOMqwQrF28dw8vn1XwdGWCjS5oOzaJynh97G+IlQDJCgJK W8cGz/ovgSwwBQ1d5ZsSknVblYcDrs3jaNCyGY0mSWx0auoq9kI1eTtjWstUNUb8kdViW+ Asqx7ITPhYEzZACIXadctsa25WzX9IA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-krjSLKVKMcyQj9XTqwETCw-1; Tue, 03 Aug 2021 11:03:44 -0400 X-MC-Unique: krjSLKVKMcyQj9XTqwETCw-1 Received: by mail-wr1-f69.google.com with SMTP id q13-20020a05600000cdb02901545f1bdac1so3930778wrx.4 for ; Tue, 03 Aug 2021 08:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7tbb0CsnnLf2HSZfxDfKO/Er3Zkctrt268hAInT4vLU=; b=c97WDpO6xArMBeHTh7HjcSuROXEQGyYyEno+uEQ7RzbHhuB0lqb01L1pMV8NiCB/Fg 0vPOekNOEUmWI0HCA2FC9SD2UOm3bulHrC0HjiSNWOCMRdhGQ+dXVhiWqUiKldeIYDgs 85/4Q9pXw7heezJz4oGLoqqwxTViDRo/14hsezblmsw/KE6j6CxbYoUnTGreE60r0+li IbGhxuna51bTk1eHKcQeXIysHLvWy+vVefrjiBaE0F/tZloBgiHRm90ueTUETK5QEQK3 Q2taLmtvjf47+mdqJFxjWBKuNWhmuwN829qRzNJT5ItVVluQt34P4ZRWdVXZj164qvoZ 4dTg== X-Gm-Message-State: AOAM532EGhFEVZQdAb3v+stCTbrgcxueVLnJvjspl3OatGgXgvaSpiv+ duMA+Z+0ooPETlMl0SDPDBj/QruD0YXdsGj6mNZGYLH2WOwcdTMTCfBMf4O54TdJPDJhRMfWnAA UIXPB7jcI3Es3jydii1vaQ0HWW3lBZZKnXD5z6I8I X-Received: by 2002:a1c:4c06:: with SMTP id z6mr4843730wmf.163.1628003023104; Tue, 03 Aug 2021 08:03:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykRywpEC7AOtnyF33drX5yQPQK6cTLMRKJswnyy1gmxHAG7bcbQHRlUM/7z8pByC9MVYVggHDv1kinAc16ErE= X-Received: by 2002:a1c:4c06:: with SMTP id z6mr4843706wmf.163.1628003022887; Tue, 03 Aug 2021 08:03:42 -0700 (PDT) MIME-Version: 1.0 References: <20210803141621.780504-1-bigeasy@linutronix.de> <20210803141621.780504-7-bigeasy@linutronix.de> In-Reply-To: <20210803141621.780504-7-bigeasy@linutronix.de> From: Karol Herbst Date: Tue, 3 Aug 2021 17:03:32 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions. To: Sebastian Andrzej Siewior Cc: LKML , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , nouveau Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 3, 2021 at 4:25 PM Sebastian Andrzej Siewior wrote: > > The functions get_online_cpus() and put_online_cpus() have been > deprecated during the CPU hotplug rework. They map directly to > cpus_read_lock() and cpus_read_unlock(). > > Replace deprecated CPU-hotplug functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/x86/mm/mmio-mod.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c > index cd768dafca9e9..933a2ebad471b 100644 > --- a/arch/x86/mm/mmio-mod.c > +++ b/arch/x86/mm/mmio-mod.c > @@ -376,12 +376,12 @@ static void enter_uniprocessor(void) > goto out; > } > > - get_online_cpus(); > + cpus_read_lock(); > cpumask_copy(downed_cpus, cpu_online_mask); > cpumask_clear_cpu(cpumask_first(cpu_online_mask), downed_cpus); > if (num_online_cpus() > 1) > pr_notice("Disabling non-boot CPUs...\n"); > - put_online_cpus(); > + cpus_read_unlock(); > > for_each_cpu(cpu, downed_cpus) { > err = remove_cpu(cpu); > -- > 2.32.0 > Reviewed-by: Karol Herbst