From: Daeho Jeong <firstname.lastname@example.org> To: Eric Biggers <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Daeho Jeong <email@example.com> Subject: Re: [f2fs-dev] [PATCH] f2fs: fix race of pending_pages in decompression Date: Fri, 4 Dec 2020 16:01:54 +0900 [thread overview] Message-ID: <CACOAw_wfew8xER-CibUtddRKVtcr3k_iGzjQ-bVYxqRUuEVCcw@mail.gmail.com> (raw) In-Reply-To: <X8nGvfEeTDTLa6FL@sol.localdomain> Thanks for the explanation about verity. I got your point. Thanks~ 2020년 12월 4일 (금) 오후 2:18, Eric Biggers <firstname.lastname@example.org>님이 작성: > > On Fri, Dec 04, 2020 at 02:00:34PM +0900, Daeho Jeong wrote: > > I think I don't understand how verity works. > > Right after verity is enabled on a file, is the verity logic working > > for the whole file data area? > > Or it's just working for the data area which is updated after verity is enabled? > > > > It's for the whole file. > > My point is just that if there is a bio that saw that verity isn't enabled yet > when it started and therefore STEP_VERITY didn't get set in the > bio_post_read_ctx (or the bio_post_read_ctx didn't get allocated due to one not > being needed), then the filesystem shouldn't change its mind and try to verify > the pages when the bio completes if verity happened to be enabled concurrently. > It's too late for that bio. > > - Eric
next prev parent reply other threads:[~2020-12-04 7:03 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 0:58 Daeho Jeong 2020-12-04 3:28 ` [f2fs-dev] " Eric Biggers 2020-12-04 3:43 ` Daeho Jeong 2020-12-04 4:01 ` Eric Biggers 2020-12-04 4:31 ` Daeho Jeong 2020-12-04 4:48 ` Daeho Jeong 2020-12-04 4:51 ` Eric Biggers 2020-12-04 5:00 ` Daeho Jeong 2020-12-04 5:18 ` Eric Biggers 2020-12-04 7:01 ` Daeho Jeong [this message] 2020-12-04 18:29 ` Jaegeuk Kim 2020-12-05 3:40 ` Daeho Jeong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACOAw_wfew8xER-CibUtddRKVtcr3k_iGzjQ-bVYxqRUuEVCcw@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [f2fs-dev] [PATCH] f2fs: fix race of pending_pages in decompression' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).