From: Daeho Jeong <daeho43@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix race of pending_pages in decompression
Date: Fri, 4 Dec 2020 13:31:02 +0900 [thread overview]
Message-ID: <CACOAw_y2HRE8CDk-HAjA6w_HzGJpRpivPY5zKRMC4_SNYTnTGg@mail.gmail.com> (raw)
In-Reply-To: <X8m0qbd7rvQyiwOt@sol.localdomain>
> Are you sure? I thought that compression (and encryption) apply to the whole
> file, including any Merkle tree blocks past i_size.
This "dic" structure is only for "de"compression, so we don't need to
worry about going beyond i_size case.
> Also, even if you include the i_size check, it's still wrong to check
> fsverity_active() in the middle of the I/O because FS_IOC_ENABLE_VERITY can
> execute concurrently, causing fsverity_active() to return false at the beginning
> of the I/O and true later in the I/O. It needs to be checked only once, at the
> beginning...
Got it. Our previous implementation didn't consider this case. Need to fix this.
Thanks,
next prev parent reply other threads:[~2020-12-04 4:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 0:58 [PATCH] f2fs: fix race of pending_pages in decompression Daeho Jeong
2020-12-04 3:28 ` [f2fs-dev] " Eric Biggers
2020-12-04 3:43 ` Daeho Jeong
2020-12-04 4:01 ` Eric Biggers
2020-12-04 4:31 ` Daeho Jeong [this message]
2020-12-04 4:48 ` Daeho Jeong
2020-12-04 4:51 ` Eric Biggers
2020-12-04 5:00 ` Daeho Jeong
2020-12-04 5:18 ` Eric Biggers
2020-12-04 7:01 ` Daeho Jeong
2020-12-04 18:29 ` Jaegeuk Kim
2020-12-05 3:40 ` Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACOAw_y2HRE8CDk-HAjA6w_HzGJpRpivPY5zKRMC4_SNYTnTGg@mail.gmail.com \
--to=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=ebiggers@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).