From: Masami Ichikawa <masami256@gmail.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
containers@lists.linux-foundation.org, lkp@01.org,
xiaolong.ye@intel.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 64fa03de33: BUG:Dentry_still_in_use
Date: Mon, 8 May 2017 20:47:38 +0900 [thread overview]
Message-ID: <CACOXgS9a=avAWZEre1Q1CGjSHeq78Pkq1fYfwPjiyEX-u=B5wQ@mail.gmail.com> (raw)
In-Reply-To: <20170508044408.GA11400@mail.hallyn.com>
On Mon, May 8, 2017 at 1:44 PM, Serge E. Hallyn <serge@hallyn.com> wrote:
> From 6a3fb632f67f8425c6e76c65dad8115f1550d2a0 Mon Sep 17 00:00:00 2001
> From: Serge Hallyn <serge@hallyn.com>
> Date: Sun, 7 May 2017 23:40:42 -0500
> Subject: [PATCH 1/1] cap_inode_getsecurity: don't pin dentry (fold up)
>
> This should fix the "Dentry_still_in_use" reported by the kernel
> test robot.
>
> Signed-off-by: Serge Hallyn <serge@hallyn.com>
> ---
> security/commoncap.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/security/commoncap.c b/security/commoncap.c
> index a1a2935..c970b71 100644
> --- a/security/commoncap.c
> +++ b/security/commoncap.c
> @@ -406,21 +406,21 @@ int cap_inode_getsecurity(struct inode *inode, const char *name, void **buffer,
> &tmpbuf, size, GFP_NOFS);
>
> if (ret < 0)
> - return ret;
> + goto out;
>
> fs_ns = inode->i_sb->s_user_ns;
> cap = (struct vfs_cap_data *) tmpbuf;
> if (is_v2header(ret, cap->magic_etc)) {
> /* If this is sizeof(vfs_cap_data) then we're ok with the
> * on-disk value, so return that. */
> - if (alloc)
> + if (alloc) {
> *buffer = tmpbuf;
> - else
> - kfree(tmpbuf);
> - return ret;
> + tmpbuf = NULL;
> + }
> + goto out;
> } else if (!is_v3header(ret, cap->magic_etc)) {
> - kfree(tmpbuf);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out;
> }
>
> nscap = (struct vfs_ns_cap_data *) tmpbuf;
> @@ -434,14 +434,14 @@ int cap_inode_getsecurity(struct inode *inode, const char *name, void **buffer,
> if (alloc) {
> *buffer = tmpbuf;
> nscap->rootid = cpu_to_le32(mappedroot);
> - } else
> - kfree(tmpbuf);
> - return size;
> + tmpbuf = NULL;
> + }
> + goto out;
> }
>
> if (!rootid_owns_currentns(kroot)) {
> - kfree(tmpbuf);
> - return -EOPNOTSUPP;
> + ret = -EOPNOTSUPP;
> + goto out;
> }
>
> /* This comes from a parent namespace. Return as a v2 capability */
> @@ -459,6 +459,9 @@ int cap_inode_getsecurity(struct inode *inode, const char *name, void **buffer,
> cap->magic_etc = cpu_to_le32(magic);
> }
> }
> +
> +out:
> + dput(dentry);
> kfree(tmpbuf);
> return size;
If ret is set to some error code, e.g. -EINVAL, then jump to out
label, this function should return error code, doesn't it?
> }
> --
> 2.7.4
>
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers
--
/**
* Masami Ichikawa
* email: masami256@gmail.com
*/
next prev parent reply other threads:[~2017-05-08 11:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 9:21 64fa03de33: BUG:Dentry_still_in_use kernel test robot
2017-05-08 4:44 ` Serge E. Hallyn
2017-05-08 11:47 ` Masami Ichikawa [this message]
2017-05-08 15:49 ` Serge E. Hallyn
2017-05-08 18:11 ` [PATCH v4] Introduce v3 namespaced file capabilities Serge E. Hallyn
2017-05-09 16:55 ` Eric W. Biederman
2017-05-09 20:37 ` Serge E. Hallyn
2017-05-09 22:27 ` Eric W. Biederman
2017-06-13 15:47 ` Stefan Berger
2017-06-13 17:14 ` Tycho Andersen
2017-06-13 17:42 ` Stefan Berger
2017-06-13 20:51 ` Tycho Andersen
2017-06-13 17:45 ` James Bottomley
2017-06-13 20:46 ` Tycho Andersen
2017-06-13 20:49 ` Stefan Berger
2017-06-13 20:53 ` Tycho Andersen
2017-06-13 20:58 ` Stefan Berger
2017-06-13 20:59 ` Mimi Zohar
2017-06-13 21:09 ` Tycho Andersen
2017-06-13 17:18 ` Serge E. Hallyn
2017-06-13 18:12 ` Stefan Berger
2017-06-13 23:55 ` Serge E. Hallyn
2017-06-14 12:27 ` Stefan Berger
2017-06-15 3:05 ` Serge E. Hallyn
2017-06-16 9:02 ` Christian Brauner
2017-06-16 22:24 ` Stefan Berger
2017-06-17 20:56 ` Stefan Berger
2017-06-18 22:14 ` Serge E. Hallyn
2017-06-19 1:13 ` Stefan Berger
2017-06-19 13:05 ` Stefan Berger
2017-06-20 6:23 ` Serge E. Hallyn
2017-06-19 21:34 ` Eric W. Biederman
2017-06-20 5:42 ` Amir Goldstein
2017-06-20 12:19 ` Stefan Berger
2017-06-20 17:33 ` Stefan Berger
2017-06-20 19:56 ` Amir Goldstein
2017-06-20 19:57 ` Vivek Goyal
2017-06-13 23:42 ` Serge E. Hallyn
2017-06-13 23:50 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACOXgS9a=avAWZEre1Q1CGjSHeq78Pkq1fYfwPjiyEX-u=B5wQ@mail.gmail.com' \
--to=masami256@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=serge@hallyn.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).