From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Lee <steven_lee@aspeedtech.com>
Subject: Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning
Date: Mon, 7 Jun 2021 04:11:28 +0000 [thread overview]
Message-ID: <CACPK8Xc1hKarizpPAWNmx1sHrPTuak0hhwZ4ZO09+iMSR+cmiA@mail.gmail.com> (raw)
In-Reply-To: <20210607013020.85885-1-andrew@aj.id.au>
On Mon, 7 Jun 2021 at 01:30, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The card timing and the bus frequency are not changed atomically with
> respect to calls to the set_clock() callback in the driver. The result
> is the driver sees a transient state where there's a mismatch between
> the two and thus the inputs to the phase correction calculation
> formula are garbage.
>
> Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
> though the change does make bad configurations less likely to be
> noticed.
>
> Reported-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/mmc/host/sdhci-of-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
> index d001c51074a0..e4665a438ec5 100644
> --- a/drivers/mmc/host/sdhci-of-aspeed.c
> +++ b/drivers/mmc/host/sdhci-of-aspeed.c
> @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,
>
> tap = div_u64(phase_period_ps, prop_delay_ps);
> if (tap > ASPEED_SDHCI_NR_TAPS) {
> - dev_warn(dev,
> + dev_dbg(dev,
> "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
> tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
> tap = ASPEED_SDHCI_NR_TAPS;
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-06-07 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 1:30 [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning Andrew Jeffery
2021-06-07 4:11 ` Joel Stanley [this message]
2021-06-08 13:15 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xc1hKarizpPAWNmx1sHrPTuak0hhwZ4ZO09+iMSR+cmiA@mail.gmail.com \
--to=joel@jms.id.au \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=steven_lee@aspeedtech.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).