From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751605AbdCABAs (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 20:00:48 -0500
Received: from mail-yw0-f193.google.com ([209.85.161.193]:35207 "EHLO
        mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751468AbdCABAq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 20:00:46 -0500
MIME-Version: 1.0
In-Reply-To: <20170228201404.32125-1-raltherr@google.com>
References: <20170228201404.32125-1-raltherr@google.com>
From: Joel Stanley <joel@jms.id.au>
Date: Wed, 1 Mar 2017 11:20:26 +1030
X-Google-Sender-Auth: HS18Fuqsf_tYdNxSna8iKeAebKg
Message-ID: <CACPK8Xc9i+SsCFx4PUCC_YhqUAHTWOzP1xwkP8A7o0knJ7TsoQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] Documentation: dt-bindings: Document bindings for
 Aspeed AST2400/AST2500 ADC
To: Rick Altherr <raltherr@google.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, jdelvare@suse.com,
        Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 1, 2017 at 6:44 AM, Rick Altherr <raltherr@google.com> wrote:
> Signed-off-by: Rick Altherr <raltherr@google.com>

Acked-by: Joel Stanley <joel@jms.id.au>

> ---
>  .../devicetree/bindings/hwmon/aspeed_adc.txt       | 48 ++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed_adc.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed_adc.txt b/Documentation/devicetree/bindings/hwmon/aspeed_adc.txt
> new file mode 100644
> index 000000000000..9e481668c4d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/aspeed_adc.txt
> @@ -0,0 +1,48 @@
> +Aspeed AST2400/2500 ADC
> +
> +This device is a 10-bit converter for 16 voltage channels.  All inputs are
> +single ended.  Each channel can be individually enabled to allow for use of
> +alternate pin functions.
> +
> +1) adc node
> +
> +  Required properties:
> +  - compatible : Should be one of
> +       "aspeed,ast2400-adc"
> +       "aspeed,ast2500-adc"
> +  - reg : memory window mapping address and length
> +  - #address-cells : must be <1> corresponding to the channel child binding
> +  - #size-cells : must be <0> corresponding to the channel child binding
> +  - clocks : Input clock used to derive the sample clock. Expected to be the
> +    SoC's APB clock.
> +  - update-interval-ms : initial time between updates on a channel
> +
> +  The node contains child nodes for each channel that the platform uses.
> +
> +  Example adc node:
> +    adc@1e6e9000 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       compatible = "aspeed,ast2400-adc";
> +       reg = <0x1e6e9000 0xB0>;
> +       clocks = <&clk_apb>;
> +       update-interval-ms = <100>;
> +
> +       [ child node definitions... ]
> +    };
> +
> +2) channel nodes
> +
> +  Optional properties:
> +  - status: indicates the operational status of the device.
> +    Value must be either "disabled" or "okay".
> +  - label : string describing the monitored value
> +
> +  Example channel node:
> +  channel@1 {
> +       status = "okay";
> +       label = "3V3 rail";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc0_default>;
> +  };
> --
> 2.11.0.483.g087da7b7c-goog
>