From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B33C49ED6 for ; Wed, 11 Sep 2019 14:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ABB7207FC for ; Wed, 11 Sep 2019 14:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="JhSfdGDL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbfIKOtI (ORCPT ); Wed, 11 Sep 2019 10:49:08 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35675 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727627AbfIKOtI (ORCPT ); Wed, 11 Sep 2019 10:49:08 -0400 Received: by mail-qt1-f194.google.com with SMTP id k10so25604375qth.2; Wed, 11 Sep 2019 07:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A5XOn0vC4GPgnCNAb2xJhPh7fm7Qsc3YVcoeu66V0ow=; b=JhSfdGDLWHQchSsKTTbaYL2d3lanGWh1bU6snzqMqlYUsbTmgquu741IO2y4CzLnnn xFF9+5sLDaKVVLzlMzpM5GNJHAe0EdZjfADYanypoGJBIcqS7xQozfjP/J0VtWg1MKnl T/6lk/ytL2NJX3N6br94MvUgja326wcjG36kI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A5XOn0vC4GPgnCNAb2xJhPh7fm7Qsc3YVcoeu66V0ow=; b=ff6sIchsU4uoVZRWEn9qoCOcItZquiEFzjLbiiLqY1L1A1ajNuOuxEULRzvAU92zxW FctkfGNuiTLZDpHbsmFAMGHeuk/BqYs00SOhJQwKuj1g9yie0oIA4PIIgdE5yWH78br4 4xQgepGnAnoRyA4SlFOuMu5WmsLYy+Qyk9aezBlsoeY5vExg9lcDCQZCFEGcSQf25OsB 8HPRqqO6aD6dB4iuQMUX/UCGMUNw1hIPpxz1HckScm7Kr9xt6JrrtYpTZGnLnL39S5Rh dfFqKlGP0wrLv+MXkeZKWNdcqilAaJDtKy0SmGyemzlkNvHA5/H0x5HcIWcQ+KauG1Ey DP2w== X-Gm-Message-State: APjAAAV8OQ0bYPbvnzFdW6yWoMmhY5kANGBpuPvuDRv57vgb+we1fAbm FitCrox00novGB6HqTr+Llw2vl7zeYwVy6dv/Bc= X-Google-Smtp-Source: APXvYqwWsmekgnVOZyP3ztRXLVkJUawqY8waZNluPJpoBtGqhHcgvfBOQH1tISxUZoQoAh6xx+1tOYTyMaOU7g5POGA= X-Received: by 2002:ac8:2e94:: with SMTP id h20mr36118219qta.234.1568213346860; Wed, 11 Sep 2019 07:49:06 -0700 (PDT) MIME-Version: 1.0 References: <20190910213734.3112330-1-vijaykhemka@fb.com> In-Reply-To: From: Joel Stanley Date: Wed, 11 Sep 2019 14:48:54 +0000 Message-ID: Subject: Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500 To: Florian Fainelli , Benjamin Herrenschmidt Cc: Vijay Khemka , "David S. Miller" , YueHaibing , Andrew Lunn , Kate Stewart , Mauro Carvalho Chehab , Luis Chamberlain , Thomas Gleixner , netdev@vger.kernel.org, Linux Kernel Mailing List , "openbmc @ lists . ozlabs . org" , linux-aspeed , Sai Dasari Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ben, On Tue, 10 Sep 2019 at 22:05, Florian Fainelli wrote: > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with IPV6 > > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > > it works perfectly fine with IPV6. > > > > Verified with IPV6 enabled and can do ssh. > > How about IPv4, do these packets have problem? If not, can you continue > advertising NETIF_F_IP_CSUM but take out NETIF_F_IPV6_CSUM? > > > > > Signed-off-by: Vijay Khemka > > --- > > drivers/net/ethernet/faraday/ftgmac100.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c > > index 030fed65393e..591c9725002b 100644 > > --- a/drivers/net/ethernet/faraday/ftgmac100.c > > +++ b/drivers/net/ethernet/faraday/ftgmac100.c > > @@ -1839,8 +1839,9 @@ static int ftgmac100_probe(struct platform_device *pdev) > > if (priv->use_ncsi) > > netdev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER; > > > > - /* AST2400 doesn't have working HW checksum generation */ > > - if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac"))) > > + /* AST2400 and AST2500 doesn't have working HW checksum generation */ > > + if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac") || > > + of_device_is_compatible(np, "aspeed,ast2500-mac"))) Do you recall under what circumstances we need to disable hardware checksumming? Cheers, Joel > > netdev->hw_features &= ~NETIF_F_HW_CSUM; > > if (np && of_get_property(np, "no-hw-checksum", NULL)) > > netdev->hw_features &= ~(NETIF_F_HW_CSUM | NETIF_F_RXCSUM); > > > > > -- > Florian