From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbdKGFCE (ORCPT ); Tue, 7 Nov 2017 00:02:04 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:55443 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbdKGFCB (ORCPT ); Tue, 7 Nov 2017 00:02:01 -0500 X-Google-Smtp-Source: ABhQp+SNBQRruia7gf7cfN6a9C+wGa3eScLmifzuggeAOqquYMQh3deNixfNSVcQhTriRTmFK4fF8HgMFCLzdfsBZZc= MIME-Version: 1.0 In-Reply-To: <20171101040457.1200-3-andrew@aj.id.au> References: <20171101040457.1200-1-andrew@aj.id.au> <20171101040457.1200-3-andrew@aj.id.au> From: Joel Stanley Date: Tue, 7 Nov 2017 15:31:39 +1030 X-Google-Sender-Auth: xYbnMccRiDXP-FigrewMT--V61M Message-ID: Subject: Re: [PATCH v3 2/2] gpio: aspeed: Add support for reset tolerance To: Andrew Jeffery Cc: linux-gpio@vger.kernel.org, Linus Walleij , Rob Herring , Mark Rutland , frowand.list@gmail.com, ckeepax@opensource.wolfsonmicro.com, ldewangan@nvidia.com, Ryan Chen , Linux Kernel Mailing List , devicetree , OpenBMC Maillist , linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 1, 2017 at 2:34 PM, Andrew Jeffery wrote: > Use the new pinconf parameter for state persistence to expose the > associated capability of the Aspeed GPIO controller. > > Signed-off-by: Andrew Jeffery I took a look and checked the offsets against the datasheet. LGTM. Reviewed-by: Joel Stanley Cheers, Joel