From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933480AbcKCW75 (ORCPT ); Thu, 3 Nov 2016 18:59:57 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34009 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbcKCW7y (ORCPT ); Thu, 3 Nov 2016 18:59:54 -0400 MIME-Version: 1.0 In-Reply-To: <1478097481-14895-2-git-send-email-andrew@aj.id.au> References: <1478097481-14895-1-git-send-email-andrew@aj.id.au> <1478097481-14895-2-git-send-email-andrew@aj.id.au> From: Joel Stanley Date: Fri, 4 Nov 2016 09:29:32 +1030 X-Google-Sender-Auth: Y_EUwRMLGul4mTElYOAfr0-XJds Message-ID: Subject: Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] To: Andrew Jeffery Cc: Lee Jones , Linus Walleij , Mark Rutland , Rob Herring , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA3N07br018467 On Thu, Nov 3, 2016 at 1:07 AM, Andrew Jeffery wrote: > If a pin depending on bit 6 in SCU90 is requested for GPIO, the export > will succeed but changes to the GPIO's value will not be accepted by the > hardware. This is because the pinmux driver has misconfigured the SCU by > writing 1 to the reserved bit. > > The description of SCU90[6] from the datasheet is 'Reserved, must keep > at value ”0”'. The fix is to switch pinmux from the bit-flipping macro > to explicitly configuring the .enable and .disable values to zero. > > The patch has been tested on an AST2500 EVB. > > Fixes: 56e57cb6c07f (pinctrl: Add pinctrl-aspeed-g5 driver) > Reported-by: Uma Yadlapati > Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley And tested-by. > This patch should be applied for 4.9. In the future I think we should send fixes separately from the rest of the series, so it's clear to Linus where we expect patches to end up. Perhaps Linus can share his preference with us? Cheers, Joel > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > index c8c72e8259d3..87b46390b695 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > @@ -26,7 +26,7 @@ > > #define ASPEED_G5_NR_PINS 228 > > -#define COND1 SIG_DESC_BIT(SCU90, 6, 0) > +#define COND1 { SCU90, BIT(6), 0, 0 } > #define COND2 { SCU94, GENMASK(1, 0), 0, 0 } > > #define B14 0 > -- > 2.7.4 >